From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9654C433EF for ; Thu, 12 May 2022 15:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39CFD6B0074; Thu, 12 May 2022 11:29:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34C0D6B0075; Thu, 12 May 2022 11:29:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2131C6B0078; Thu, 12 May 2022 11:29:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1280F6B0074 for ; Thu, 12 May 2022 11:29:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D98CC6056C for ; Thu, 12 May 2022 15:29:48 +0000 (UTC) X-FDA: 79457476056.03.FDAF188 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf12.hostedemail.com (Postfix) with ESMTP id 575174009F for ; Thu, 12 May 2022 15:29:22 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id o69so5492002pjo.3 for ; Thu, 12 May 2022 08:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7epJTdRtz8ytdA7Utn31+NXZs2HtBeeNX7bVpN/MwEE=; b=oWkmUWIotuY3hw15NeyY9Iex85NSglOKVVENUxyQGPOnp57jSo5srkPr4aU6mbpkWf DcAWK5xOtDlW4eMge2b973h+I1jrO6V+pb9OfrFZNYYyXG8z84ABGR/1WSk53GQIXPwe eycIHWO9FOGJAKvbTgOdAzXYycrb5p80pAw1xoB8sG/eR0uQQi9vsNpMyA3s5Wil8RJp sOXCRd77QMt7vDFYUyqYjMlyXs/isHjjauLFVMhTamXymvbXVdqQ9WL/eMYExZtrQ3a2 h19wBTT5sjs4pCGEDH0duAI18i8/oVI1dTpELovthJ8HenFpcjJL0oQ31jEYTcQKO1cw K6qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7epJTdRtz8ytdA7Utn31+NXZs2HtBeeNX7bVpN/MwEE=; b=43ZTmsVC/ZBACn0WUa1yK7/fsZJAWMFqoRNncojxg/7OJ0ZrTp/70vogrCZFx2wnzN GRdug5J9dkpmKKT9h0MAY0r3dTY4Qn5g89rlRnC8CMwZ2Sb24uCJVymLzvJoEcQpamyt koZ3+H23SIUD/qQO3n/miIrAzPB5kbbrInVbtJJfE+xhwDKlELpz98qe79QvzBdFNT2p g2f/Qhv0ILWJLFpnLJqbT7AtiVJgzBII79NS1fhD9hAr8m8zif9xWwvLpQHqPUxOgc8V ZIbJ9tXfon2Kb+R2xXGUpBgPLgNk9hwox9piOPlfqRGrRAV3mxEoE+SY9cQCelhkK+p3 7G1w== X-Gm-Message-State: AOAM531vWhpSAF6ZRPyuHScNeS8tfmO9kmWY9dHBJqV9DPKaltpbIJYH wanc6ezh5a7ezyPg+bIV4Kq7HA== X-Google-Smtp-Source: ABdhPJywV11QbxqEEIqi2h3e/6mR0N+JCgW5XA1dNaSgjidm8KmEaVToTsNTUo844tIGd0Z1A2GNMA== X-Received: by 2002:a17:902:a988:b0:158:9877:6c2c with SMTP id bh8-20020a170902a98800b0015898776c2cmr485723plb.80.1652369384675; Thu, 12 May 2022 08:29:44 -0700 (PDT) Received: from localhost ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id l20-20020a056a00141400b0050dc76281a1sm3992770pfu.123.2022.05.12.08.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 08:29:44 -0700 (PDT) Date: Thu, 12 May 2022 23:29:31 +0800 From: Muchun Song To: liqiong Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: change "char *bdi_unknown_name" to "char bdi_unknown_name[]" Message-ID: References: <20220512082637.24649-1-liqiong@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512082637.24649-1-liqiong@nfschina.com> X-Rspamd-Queue-Id: 575174009F X-Stat-Signature: tdi1mbg5mj99f13rs15gbbdr6k1xsaep X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=oWkmUWIo; spf=pass (imf12.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam09 X-HE-Tag: 1652369362-33623 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 12, 2022 at 04:26:37PM +0800, liqiong wrote: > "char bdi_unknown_nam[]" string form declares a single variable. > It is better then "char *bdi_unknown_name" which creates two > variables. > Sorry, I do not understand what you are saying here. Creating two variables means what? Thanks. > Signed-off-by: liqiong > --- > mm/backing-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 7176af65b103..4982ccc63536 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -20,7 +20,7 @@ struct backing_dev_info noop_backing_dev_info; > EXPORT_SYMBOL_GPL(noop_backing_dev_info); > > static struct class *bdi_class; > -static const char *bdi_unknown_name = "(unknown)"; > +static const char bdi_unknown_name[] = "(unknown)"; > > /* > * bdi_lock protects bdi_tree and updates to bdi_list. bdi_list has RCU > -- > 2.11.0 > >