From: Jiri Pirko <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: "David S. Miller" <[email protected]>,
Eric Dumazet <[email protected]>,
Jakub Kicinski <[email protected]>, Paolo Abeni <[email protected]>,
kernel test robot <[email protected]>,
Dan Carpenter <[email protected]>,
Moshe Shemesh <[email protected]>, Jiri Pirko <[email protected]>,
Fernanda Ma'rouf <[email protected]>,
netdev Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
kbuild Mailing List <[email protected]>,
kbuild-all Mailing List <[email protected]>
Subject: Re: [PATCH] net: devlink: Fix missing mutex_unlock() call
Date: Mon, 1 Aug 2022 16:40:50 +0200 [thread overview]
Message-ID: <Yufl8sENNlOjsfwf@nanopsycho> (raw)
In-Reply-To: <[email protected]>
Mon, Aug 01, 2022 at 01:59:56PM CEST, [email protected] wrote:
>From: Ammar Faizi <[email protected]>
>
>Commit 2dec18ad826f forgets to call mutex_unlock() before the function
>returns in the error path:
>
> New smatch warnings:
> net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \
> returns '®ion->snapshot_lock'.
>
>Make sure we call mutex_unlock() in this error path.
>
>Reported-by: kernel test robot <[email protected]>
>Reported-by: Dan Carpenter <[email protected]>
>Fixes: 2dec18ad826f52658f7781ee995d236cc449b678 ("net: devlink: remove region snapshots list dependency on devlink->lock")
>Signed-off-by: Ammar Faizi <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
Thanks for the fix!
next prev parent reply other threads:[~2022-08-01 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 11:29 [ammarfaizi2-block:netdev/net-next/main 20/29] net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent returns '®ion->snapshot_lock' Dan Carpenter
2022-08-01 11:59 ` [PATCH] net: devlink: Fix missing mutex_unlock() call Ammar Faizi
2022-08-01 14:40 ` Jiri Pirko [this message]
2022-08-01 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yufl8sENNlOjsfwf@nanopsycho \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox