From: Al Viro <[email protected]>
To: kernel test robot <[email protected]>
Cc: [email protected], Ammar Faizi <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
[email protected]
Subject: Re: [ammarfaizi2-block:viro/vfs/work.termios2 4/8] arch/alpha/kernel/termios.c:5:5: warning: no previous prototype for 'user_termio_to_kernel_termios'
Date: Sun, 21 Aug 2022 06:11:04 +0100 [thread overview]
Message-ID: <YwG+aJKsnkurbSC6@ZenIV> (raw)
In-Reply-To: <[email protected]>
On Sun, Aug 21, 2022 at 12:07:05PM +0800, kernel test robot wrote:
> tree: https://github.com/ammarfaizi2/linux-block viro/vfs/work.termios2
> head: efc5ae91c846283431afc7bfc57e947bf1fd4158
> commit: 7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5 [4/8] termios: start unifying non-UAPI parts of asm/termios.h
> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220821/[email protected]/config)
> compiler: alpha-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/ammarfaizi2/linux-block/commit/7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5
> git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
> git fetch --no-tags ammarfaizi2-block viro/vfs/work.termios2
> git checkout 7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash arch/alpha/kernel/
Fixed and folded; incremental is
diff --git b/arch/alpha/kernel/termios.c a/arch/alpha/kernel/termios.c
index 1534f39cb9fe..a4c29a22edf7 100644
--- b/arch/alpha/kernel/termios.c
+++ a/arch/alpha/kernel/termios.c
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-#include <linux/uaccess.h>
-#include <linux/termios.h>
+#include <linux/termios_internal.h>
int user_termio_to_kernel_termios(struct ktermios *termios,
struct termio __user *termio)
diff --git b/arch/sparc/kernel/termios.c a/arch/sparc/kernel/termios.c
index 97e23d4ae2e2..ee64965c27cd 100644
--- b/arch/sparc/kernel/termios.c
+++ a/arch/sparc/kernel/termios.c
@@ -1,5 +1,5 @@
-#include <linux/uaccess.h>
-#include <linux/termios.h>
+// SPDX-License-Identifier: GPL-2.0
+#include <linux/termios_internal.h>
/*
* c_cc characters in the termio structure. Oh, how I love being
prev parent reply other threads:[~2022-08-21 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 4:07 [ammarfaizi2-block:viro/vfs/work.termios2 4/8] arch/alpha/kernel/termios.c:5:5: warning: no previous prototype for 'user_termio_to_kernel_termios' kernel test robot
2022-08-21 5:11 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwG+aJKsnkurbSC6@ZenIV \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox