Re: [PATCH v1 00/17] Profile Page, SEO, Fixed API structure, Docs

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On Wed, Mar 05, 2025 at 09:39:59PM +0700, Muhammad Rizki wrote:
> This series of patches was planned only to update profile page feature,
> since there is a change in the API structure, I also fixed
> the API response type to prevent breaking change.
> 
> To prevent more breaking change on production site in the future,
> sir Ammar has made a staging API for development stage,
> since there is a staging API version, I added an environment variable
> `PUBLIC_BASE_URL` for each environment (development or production).
> You should set `PUBLIC_BASE_URL` environment in your own server,
> there is an example file for development and production environment
> in this patch, please see `.env.development.example` and
> `.env.production.example` in root directory.

So, in my testing, the assets loading process is still broken. I had to
reapply this patch manually to get it working:

diff --git a/svelte.config.js b/svelte.config.js
index 5a6890a..40dc905 100644
--- a/svelte.config.js
+++ b/svelte.config.js
@@ -5,6 +5,7 @@ import { vitePreprocess } from "@sveltejs/vite-plugin-svelte";
 const config = {
   preprocess: vitePreprocess(),
   kit: {
+    paths: { relative: false },
     adapter: adapter({
       pages: "dist",
       assets: "dist",

That's fine. Also, I found that the delete profile photo button does
not work.

Please send follow up patches for these two problems:

1) Use 'paths: { relative: false }' to make it work on nginx.

2) Fix the 'delete' button on photo profile.

Don't send a v2 revision, just two new patches. This series is good to
be applied, just a bit incomplete...

-- 
Ammar Faizi