From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS
	autolearn=ham autolearn_force=no version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1741193684;
	bh=B8WCdVA1Vu7qf1NzwtbHSQ6KMz1cjGFsXw6SCBio4Eo=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:In-Reply-To:Message-ID:Date:From:Reply-To:Subject:To:
	 Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To:
	 Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding;
	b=MAcTMyNgMDrYQtok9F+mJ9+l6M7GP8SQsA/BgMAN4i5ftit9C5T1HSXh5mfnFgsSb
	 CLKIVrVYBjkWionzxEQOrINb0RcFJw44DP523FObyOFrXHPv9sBaBhkFD5EjvPOjy6
	 9y59Tm77Pmvied4yFFjJBc23mdiksR/Sx/AMtQVqIE6jJtM9InYvPm9q66d+keSdFt
	 sks6gqUt1rHDANqH22K807WsGrokSOAbt/qMzpdojSHZtA+biG7Ukzs8+KYNZ4fbFL
	 gum5ypHwRtUiTum1ibpsEzu0DywuvhUZ5hEcTGT6O5p7XP8KvsL8oPPkqWtCw8+VU0
	 YxHc0FNAq+NuA==
Received: from biznet-home.integral.gnuweeb.org (unknown [146.70.14.29])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id A7D3A20B4833;
	Wed,  5 Mar 2025 16:54:42 +0000 (UTC)
Date: Wed, 5 Mar 2025 23:54:35 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH v1 00/17] Profile Page, SEO, Fixed API structure, Docs
Message-ID: <Z8iBy7CI8mFDe/0i@biznet-home.integral.gnuweeb.org>
References: <20250305144018.267-1-kiizuha@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250305144018.267-1-kiizuha@gnuweeb.org>
X-Bpl: hUx9VaHkTWcLO7S8CQCslj6OzqBx2hfLChRz45nPESx5VSB/xuJQVOKOB1zSXE3yc9ntP27bV1M1
List-Id: <gwml.vger.gnuweeb.org>

On Wed, Mar 05, 2025 at 09:39:59PM +0700, Muhammad Rizki wrote:
> This series of patches was planned only to update profile page feature,
> since there is a change in the API structure, I also fixed
> the API response type to prevent breaking change.
> 
> To prevent more breaking change on production site in the future,
> sir Ammar has made a staging API for development stage,
> since there is a staging API version, I added an environment variable
> `PUBLIC_BASE_URL` for each environment (development or production).
> You should set `PUBLIC_BASE_URL` environment in your own server,
> there is an example file for development and production environment
> in this patch, please see `.env.development.example` and
> `.env.production.example` in root directory.

So, in my testing, the assets loading process is still broken. I had to
reapply this patch manually to get it working:

diff --git a/svelte.config.js b/svelte.config.js
index 5a6890a..40dc905 100644
--- a/svelte.config.js
+++ b/svelte.config.js
@@ -5,6 +5,7 @@ import { vitePreprocess } from "@sveltejs/vite-plugin-svelte";
 const config = {
   preprocess: vitePreprocess(),
   kit: {
+    paths: { relative: false },
     adapter: adapter({
       pages: "dist",
       assets: "dist",

That's fine. Also, I found that the delete profile photo button does
not work.

Please send follow up patches for these two problems:

1) Use 'paths: { relative: false }' to make it work on nginx.

2) Fix the 'delete' button on photo profile.

Don't send a v2 revision, just two new patches. This series is good to
be applied, just a bit incomplete...

-- 
Ammar Faizi