From: Ammar Faizi <[email protected]>
To: Willy Tarreau <[email protected]>
Cc: "Thomas Weißschuh" <[email protected]>,
"Zhangjin Wu" <[email protected]>,
"Nicholas Rosenberg" <[email protected]>,
"Michael William Jonathan" <[email protected]>,
"GNU/Weeb Mailing List" <[email protected]>,
"Linux Kernel Mailing List" <[email protected]>
Subject: Re: [PATCH v2 1/1] tools/nolibc: i386: Fix a stack misalign bug on _start
Date: Tue, 29 Aug 2023 19:17:10 +0700 [thread overview]
Message-ID: <ZO3hxnKlWEbT/[email protected]> (raw)
In-Reply-To: <[email protected]>
On Tue, Aug 29, 2023 at 08:21:47AM +0200, Willy Tarreau wrote:
> Indeed, good catch! However if we want to do it cleany (i.e not punch a
> 16 to 28 byes hole in the stack), we should do this instead:
>
> add $12, %esp /* the stack must be aligned to 16 ... */
> and $-16, %esp /* ... bytes after eax is pushed and ... */
> sub $12, %esp /* ... before the call. */
>
> This will only add 0 to 12 bytes depending on the existing alignment.
>
> What do you think ?
Good point. I'll send a v3 revision tomorrow.
I just saw that Linus has pulled the PR from Shuah that contains this
bug. IOW, I missed this fix for the 6.6 merge window. Let's see if it
can go to 6.6-rc2. Or maybe sooner than that.
--
Ammar Faizi
next prev parent reply other threads:[~2023-08-29 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 7:02 [PATCH v2 0/1] Fix a stack misalign bug on _start Ammar Faizi
2023-08-28 7:02 ` [PATCH v2 1/1] tools/nolibc: i386: " Ammar Faizi
2023-08-29 6:21 ` Willy Tarreau
2023-08-29 12:17 ` Ammar Faizi [this message]
2023-08-29 12:24 ` Willy Tarreau
2023-08-29 8:37 ` Zhangjin Wu
2023-08-29 12:25 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3hxnKlWEbT/[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox