From: Ammar Faizi <[email protected]>
To: "Thomas Weißschuh" <[email protected]>
Cc: Willy Tarreau <[email protected]>, Zhangjin Wu <[email protected]>,
Nicholas Rosenberg <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Michael William Jonathan <[email protected]>,
Linux Kernel Mailing List <[email protected]>
Subject: Re: [PATCH v1 1/1] tools/nolibc: i386: Fix a stack misalign bug on _start
Date: Sun, 27 Aug 2023 14:22:51 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Sun, Aug 27, 2023 at 08:53:26AM +0200, Thomas Weißschuh wrote:
> Afaik references to commits in commit messages are supposed to follow
> the same format as in the Fixes: tag.
Copied.
> Thanks for the fix!
>
> In general:
>
> Acked-by: Thomas Weißschuh <[email protected]>
I'll fix the reference format, append your acked by tag, and explain
more about the logic behind 'sub $12, %esp' in v2.
I'm currently traveling, will send the v2 revision on Monday morning
Jakarta time.
> Also a Link: tag for the Reported-by: would be nice.
I would have linked the discussion if the report were on the list.
Unfortunately, Nicholas reported it offlist.
--
Ammar Faizi
next prev parent reply other threads:[~2023-08-27 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 14:16 [PATCH v1 0/1] Fix a stack misalign bug on _start Ammar Faizi
2023-08-26 14:16 ` [PATCH v1 1/1] tools/nolibc: i386: " Ammar Faizi
2023-08-26 15:07 ` Zhangjin Wu
2023-08-26 15:55 ` Ammar Faizi
2023-08-27 6:53 ` Thomas Weißschuh
2023-08-27 7:22 ` Ammar Faizi [this message]
2023-08-26 15:20 ` [PATCH v1 0/1] " Zhangjin Wu
2023-08-26 16:04 ` Ammar Faizi
2023-08-26 16:36 ` Zhangjin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox