From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Authentication-Results: gnuweeb.org; dmarc=none (p=none dis=none) header.from=1wt.eu Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=163.172.96.212; helo=1wt.eu; envelope-from=w@1wt.eu; receiver= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by gnuweeb.org (Postfix) with ESMTP id 14A5624B3E1 for ; Sun, 3 Sep 2023 16:55:34 +0700 (WIB) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 3839tKMD028386; Sun, 3 Sep 2023 11:55:20 +0200 Date: Sun, 3 Sep 2023 11:55:20 +0200 From: Willy Tarreau To: Ammar Faizi Cc: Alviro Iskandar Setiawan , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , David Laight , Nicholas Rosenberg , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: Re: [RFC PATCH v3 2/4] tools/nolibc: x86-64: Use `rep stosb` for `memset()` Message-ID: References: <20230902133505.2176434-1-ammarfaizi2@gnuweeb.org> <20230902133505.2176434-3-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: On Sun, Sep 03, 2023 at 03:39:33PM +0700, Ammar Faizi wrote: > [ Resend, I sent it using the wrong From address. ] > > On 2023/09/03 ??3:17, Willy Tarreau wrote: > > On Sun, Sep 03, 2023 at 02:34:22AM +0700, Ammar Faizi wrote: > > > On Sun, Sep 03, 2023 at 02:28:18AM +0700, Alviro Iskandar Setiawan wrote: > > > > nit: Be consistent. Use \n\t for the memset too. > > > > > > Good catch, I'll fix that in v4 revision. > > > > Ammar, I'm overall fine with your series. I can as well add the missing \t > > to your patch while merging it, or wait for your v4, just let me know. > > I'm now traveling and will be available in Jakarta on Monday. Thus, I > actually planned to send the v4 revision on Monday. > > However, since you don't have further objections to this series, I'll > leave the trivial missing bit to you. Please merge this series and I > will not send a v4 revision. OK now merged with the \t appended. No need to spend your time on a v4 anymore. Thanks! Willy