[PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles

[PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles

[Memet Zx]

Hello,

This patch series adds custom scrollbar styles to app.css and refactors
layout styles in OrganizationMembers.svelte, RecentMessages.svelte, and
+page.svelte. It also adds a description to site.webmanifest.

Memet Zx (4):
  Add custom scrollbar styles to app.css
  Update layout styles in +layout.svelte
  Refactor layout styles in OrganizationMembers.svelte,
    RecentMessages.svelte, and +page.svelte
  Add description to site.webmanifest

 src/app.css                                   | 21 +++++++++++++++++++
 src/lib/components/OrganizationMembers.svelte |  2 +-
 src/lib/components/RecentMessages.svelte      |  2 +-
 src/routes/+layout.svelte                     |  2 +-
 src/routes/+page.svelte                       |  2 +-
 static/site.webmanifest                       |  1 +
 6 files changed, 26 insertions(+), 4 deletions(-)

-- 
2.34.1

[PATCH WEB 1/4] Add custom scrollbar styles to app.css

[Memet Zx]

to make it more elegant

Signed-off-by: Memet Zx <zxce3@gnuweeb.org>
---
 src/app.css | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/src/app.css b/src/app.css
index b5c61c9..0969457 100644
--- a/src/app.css
+++ b/src/app.css
@@ -1,3 +1,24 @@
 @tailwind base;
 @tailwind components;
 @tailwind utilities;
+
+/* width */
+::-webkit-scrollbar {
+    width: 5px;
+}
+
+/* Track */
+::-webkit-scrollbar-track {
+    background: #0a0a0a; 
+}
+ 
+/* Handle */
+::-webkit-scrollbar-thumb {
+    background: #262626;
+    border-radius: 5px;
+}
+
+/* Handle on hover */
+::-webkit-scrollbar-thumb:hover {
+    background: #555; 
+}
-- 
2.34.1

[PATCH WEB 2/4] Update layout styles in +layout.svelte

[Memet Zx]

* Change `px-20` to `px-5` for better responsiveness across all devices.

Signed-off-by: Memet Zx <zxce3@gnuweeb.org>
---
 src/routes/+layout.svelte | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/routes/+layout.svelte b/src/routes/+layout.svelte
index 21ee482..823d6c6 100644
--- a/src/routes/+layout.svelte
+++ b/src/routes/+layout.svelte
@@ -40,7 +40,7 @@
 </svelte:head>
 
 
-<div class="w-full px-20 bg-neutral-950 text-neutral-200">
+<div class="w-full px-5 bg-neutral-950 text-neutral-200">
 
   <!-- main/root element -->
   <main class="flex justify-center w-full min-h-screen">
-- 
2.34.1

[PATCH WEB 3/4] Refactor layout styles in OrganizationMembers.svelte, RecentMessages.svelte, and +page.svelte

[Memet Zx]

* Update max-width classes to improve responsiveness across different screen sizes.

Signed-off-by: Memet Zx <zxce3@gnuweeb.org>
---
 src/lib/components/OrganizationMembers.svelte | 2 +-
 src/lib/components/RecentMessages.svelte      | 2 +-
 src/routes/+page.svelte                       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/components/OrganizationMembers.svelte b/src/lib/components/OrganizationMembers.svelte
index 2443378..8892d39 100644
--- a/src/lib/components/OrganizationMembers.svelte
+++ b/src/lib/components/OrganizationMembers.svelte
@@ -7,7 +7,7 @@
 
 <div
   class="border border-neutral-800 rounded-xl overflow-hidden
-        max-w-xs md:max-w-lg lg:max-w-3xl xl:w-[20rem]"
+         md:max-w-lg lg:max-w-3xl xl:w-[20rem]"
 >
   <div class="flex px-5 py-2 border-b border-neutral-800 justify-between items-center">
     <h1 class="text-lg font-bold text-center w-full">Member List</h1>
diff --git a/src/lib/components/RecentMessages.svelte b/src/lib/components/RecentMessages.svelte
index 25fb0eb..d091285 100644
--- a/src/lib/components/RecentMessages.svelte
+++ b/src/lib/components/RecentMessages.svelte
@@ -42,7 +42,7 @@
 
 <div
   class="border border-neutral-800 rounded-xl overflow-hidden
-        max-w-xs md:max-w-lg lg:max-w-3xl xl:w-[20rem]"
+        md:max-w-lg lg:max-w-3xl xl:w-[20rem]"
 >
 
   <div class="flex px-5 py-2 border-b border-neutral-800 justify-between items-center">
diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte
index c00cf0e..d28fd57 100644
--- a/src/routes/+page.svelte
+++ b/src/routes/+page.svelte
@@ -30,7 +30,7 @@
 <section class="flex flex-col space-y-3 px-3">
 
   <!-- PROFILE SECTION -->
-  <div class="border border-neutral-800 rounded-b-xl overflow-hidden max-w-xs md:max-w-lg lg:max-w-3xl">
+  <div class="border border-neutral-800 rounded-b-xl overflow-hidden md:max-w-lg lg:max-w-3xl">
     <img
       src="/img/profile-cover.jpg"
       alt=""
-- 
2.34.1

[PATCH WEB 4/4] Add description to site.webmanifest

[Memet Zx]

* Include a `description` field in site.webmanifest for improved site metadata.

Signed-off-by: Memet Zx <zxce3@gnuweeb.org>
---
 static/site.webmanifest | 1 +
 1 file changed, 1 insertion(+)

diff --git a/static/site.webmanifest b/static/site.webmanifest
index 4c777c3..7dde35d 100644
--- a/static/site.webmanifest
+++ b/static/site.webmanifest
@@ -1,6 +1,7 @@
 {
   "name": "gnuweeb.org",
   "short_name": "gnuweeb",
+  "description": "We are working to build a community through open source technology.",
   "icons": [
     {
       "src": "/android-chrome-192x192.png",
-- 
2.34.1

Re: [PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles

[Ammar Faizi]

On Sun, Apr 21, 2024 at 09:24:32PM +0700, Memet Zx wrote:
> Hello,

Actions required:

 - Follow the proper commit message format.

 - Fix the whitespace errors.

 - Don't leave trailing whitespaces:

	<stdin>:39: trailing whitespace.
	background: #0a0a0a; 
	<stdin>:41: trailing whitespace.
	
	<stdin>:50: trailing whitespace.
	background: #555; 
	warning: 3 lines add whitespace errors.

 - Describe the responsiveness issue you're going to address in this
   series.

-- 
Ammar Faizi

Re: [PATCH WEB 1/4] Add custom scrollbar styles to app.css

[Ammar Faizi]

On Sun, Apr 21, 2024 at 09:24:33PM +0700, Memet Zx wrote:
> to make it more elegant
> 
> Signed-off-by: Memet Zx <zxce3@gnuweeb.org>

Maybe I don't understand elegancy, but what exactly do you mean by
"more elegant"?

No one, not even people in the CC list have given their review to this
series because you don't send a well formatted patchset. Don't expect
to be merged if you don't care with the reviewers side.

-- 
Ammar Faizi

Re: [PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles

[Alviro Iskandar Setiawan]

On Sun, Apr 21, 2024 at 9:25 PM Memet Zx wrote:
> Hello,
>
> This patch series adds custom scrollbar styles to app.css and refactors
> layout styles in OrganizationMembers.svelte, RecentMessages.svelte, and
> +page.svelte. It also adds a description to site.webmanifest.

You can take a look at Muhammad Rizki's series, it's a good example of
patchset that meets our standards:

  https://lore.gnuweeb.org/gwml/20231007054446.1204-1-kiizuha@gnuweeb.org/T/

GNU/Weeb has its own standard in code review, and your patchset is
definitely far from ours.

Also, use a real name. I don't believe "Zx" is a valid name (correct
me if I am wrong). As per DCO, one important requirement is that each
patch (or commit, in the case of a git pull request) must contain a
valid "Signed-off-by:" line using your real name. We unfortunately
cannot accept pseudonymous or anonymous contributions.

-- Viro