From: Dylan Yudaken <[email protected]>
To: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Cc: Kernel Team <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [PATCH liburing 2/4] add IORING_RECV_MULTISHOT to io_uring.h
Date: Tue, 28 Jun 2022 16:12:50 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
T24gVHVlLCAyMDIyLTA2LTI4IGF0IDIzOjEwICswNzAwLCBBbW1hciBGYWl6aSB3cm90ZToNCj4g
T24gNi8yOC8yMiAxMDowNCBQTSwgRHlsYW4gWXVkYWtlbiB3cm90ZToNCj4gPiBjb3B5IGZyb20g
aW5jbHVkZS91YXBpL2xpbnV4L2lvX3VyaW5nLmgNCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBE
eWxhbiBZdWRha2VuIDxkeWxhbnlAZmIuY29tPg0KPiA+IC0tLQ0KPiA+IMKgIHNyYy9pbmNsdWRl
L2xpYnVyaW5nL2lvX3VyaW5nLmggfCA1MyArKysrKysrKysrKysrKysrKysrKysrKystLS0tDQo+
ID4gLS0tLS0NCj4gPiDCoCAxIGZpbGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMTQgZGVs
ZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2xpYnVyaW5nL2lv
X3VyaW5nLmgNCj4gPiBiL3NyYy9pbmNsdWRlL2xpYnVyaW5nL2lvX3VyaW5nLmgNCj4gPiBpbmRl
eCAyZjM5MWM5Li4xZTViZGIzIDEwMDY0NA0KPiA+IC0tLSBhL3NyYy9pbmNsdWRlL2xpYnVyaW5n
L2lvX3VyaW5nLmgNCj4gPiArKysgYi9zcmMvaW5jbHVkZS9saWJ1cmluZy9pb191cmluZy5oDQo+
ID4gQEAgLTEwLDEwICsxMCw3IEBADQo+ID4gwqAgDQo+ID4gwqAgI2luY2x1ZGUgPGxpbnV4L2Zz
Lmg+DQo+ID4gwqAgI2luY2x1ZGUgPGxpbnV4L3R5cGVzLmg+DQo+ID4gLQ0KPiA+IC0jaWZkZWYg
X19jcGx1c3BsdXMNCj4gPiAtZXh0ZXJuICJDIiB7DQo+ID4gLSNlbmRpZg0KPiANCj4gRHlsYW4s
DQo+IA0KPiBUaGF0IGBleHRlcm4gIkMiYCB0aGluZyBpcyBmb3IgQysrLCB3ZSBzaG91bGRuJ3Qg
b21pdCBpdC4NCj4gDQo+IE9yIGJldHRlciBhZGQgdGhhdCB0byB0aGUga2VybmVsIHRyZWUgYXMg
d2VsbCwgaXQgd29uJ3QgYnJlYWsNCj4gdGhlIGtlcm5lbCBiZWNhdXNlIHdlIGhhdmUgYSBfX2Nw
bHVzcGx1cyBndWFyZCBoZXJlLg0KPiANCj4gSmVucyB3aGF0IGRvIHlvdSB0aGluaz8NCj4gDQo+
IEp1c3QgZm9yIHJlZmVyZW5jZSwgdGhhdCBsaW5lIGlzIGludHJvZHVjZWQgaW4gY29tbWl0Og0K
PiANCj4gwqDCoCBjb21taXQgM2Q3NGM2NzdjNDVlY2NmMzZiOTJmN2FkNGIzMzE3YWRjMWVkMDZi
Yg0KPiDCoMKgIEF1dGhvcjogQmFydCBWYW4gQXNzY2hlIDxidmFuYXNzY2hlQGFjbS5vcmc+DQo+
IMKgwqAgRGF0ZTrCoMKgIFN1biBKdW4gMjggMTI6NTg6MTkgMjAyMCAtMDcwMA0KPiANCj4gwqDC
oMKgwqDCoMKgIE1ha2UgdGhlIGxpYnVyaW5nIGhlYWRlciBmaWxlcyBhZ2FpbiBjb21wYXRpYmxl
IHdpdGggQysrDQo+IA0KPiDCoMKgwqDCoMKgwqAgSW5jbHVkZSA8YXRvbWljPiBpbnN0ZWFkIG9m
IDxzdGRhdG9taWMuaD4gaWYgYnVpbHQgd2l0aCBhIEMrKw0KPiBjb21waWxlci4NCj4gDQo+IMKg
wqDCoMKgwqDCoCBGaXhlczogYjljMGJmNzlhYTg3ICgic3JjL2luY2x1ZGUvbGlidXJpbmcvYmFy
cmllci5oOiBVc2UgQzExDQo+IGF0b21pY3MiKQ0KPiDCoMKgwqDCoMKgwqAgU2lnbmVkLW9mZi1i
eTogQmFydCBWYW4gQXNzY2hlIDxidmFuYXNzY2hlQGFjbS5vcmc+DQo+IMKgwqDCoMKgwqDCoCBT
aWduZWQtb2ZmLWJ5OiBKZW5zIEF4Ym9lIDxheGJvZUBrZXJuZWwuZGs+DQo+IA0KPiDCoCBzcmMv
aW5jbHVkZS9saWJ1cmluZy5owqDCoMKgwqDCoMKgwqDCoMKgIHzCoCA4ICsrKystLS0tDQo+IMKg
IHNyYy9pbmNsdWRlL2xpYnVyaW5nL2JhcnJpZXIuaMKgIHwgMzcNCj4gKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKystLQ0KPiDCoCBzcmMvaW5jbHVkZS9saWJ1cmluZy9pb191cmlu
Zy5oIHzCoCA4ICsrKysrKysrDQo+IMKgIDMgZmlsZXMgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygr
KSwgNiBkZWxldGlvbnMoLSkNCj4gDQo+IEFkZGluZyB0aGUgYXV0aG9yIHRvIHRoZSBDQyBsaXN0
Lg0KPiANCg0KWWVhaCB0aGlzIG1ha2VzIHNlbnNlLiBJIHRoaW5rIEkganVzdCBhc3N1bWVkIHRo
ZSBmaWxlIHdhcyBhIG1hbnVhbA0KY29weSBvZiB0aGUgbGF0ZXN0IGtlcm5lbCBvbmUgd2hpY2gg
aXQgY2xlYXJseSBpcyBub3QuDQoNCkknbGwgZml4IGl0IHVwIGluIHYyDQo=
On Tue, 2022-06-28 at 23:10 +0700, Ammar Faizi wrote:
> On 6/28/22 10:04 PM, Dylan Yudaken wrote:
> > copy from include/uapi/linux/io_uring.h
> >
> > Signed-off-by: Dylan Yudaken <[email protected]>
> > ---
> > src/include/liburing/io_uring.h | 53 ++++++++++++++++++++++++----
> > -----
> > 1 file changed, 39 insertions(+), 14 deletions(-)
> >
> > diff --git a/src/include/liburing/io_uring.h
> > b/src/include/liburing/io_uring.h
> > index 2f391c9..1e5bdb3 100644
> > --- a/src/include/liburing/io_uring.h
> > +++ b/src/include/liburing/io_uring.h
> > @@ -10,10 +10,7 @@
> >
> > #include <linux/fs.h>
> > #include <linux/types.h>
> > -
> > -#ifdef __cplusplus
> > -extern "C" {
> > -#endif
>
> Dylan,
>
> That `extern "C"` thing is for C++, we shouldn't omit it.
>
> Or better add that to the kernel tree as well, it won't break
> the kernel because we have a __cplusplus guard here.
>
> Jens what do you think?
>
> Just for reference, that line is introduced in commit:
>
> commit 3d74c677c45eccf36b92f7ad4b3317adc1ed06bb
> Author: Bart Van Assche <[email protected]>
> Date: Sun Jun 28 12:58:19 2020 -0700
>
> Make the liburing header files again compatible with C++
>
> Include <atomic> instead of <stdatomic.h> if built with a C++ compiler.
>
> Fixes: b9c0bf79aa87 ("src/include/liburing/barrier.h: Use C11 atomics")
> Signed-off-by: Bart Van Assche <[email protected]>
> Signed-off-by: Jens Axboe <[email protected]>
>
> src/include/liburing.h | 8 ++++----
> src/include/liburing/barrier.h | 37 +++++++++++++++++++++++++++++++++++--
> src/include/liburing/io_uring.h | 8 ++++++++
> 3 files changed, 47 insertions(+), 6 deletions(-)
>
> Adding the author to the CC list.
>
Yeah this makes sense. I think I just assumed the file was a manual
copy of the latest kernel one which it clearly is not.
I'll fix it up in v2
WARNING: multiple messages have this Message-ID (diff)
From: Dylan Yudaken <[email protected]>
To: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Cc: Kernel Team <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [PATCH liburing 2/4] add IORING_RECV_MULTISHOT to io_uring.h
Date: Tue, 28 Jun 2022 16:12:50 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
Message-ID: <20220628161250.E_-GaeRotHvcw1BL34GDF1J2q2kdLtAkaEeWlzGkdI0@z> (raw)
In-Reply-To: <[email protected]>
On Tue, 2022-06-28 at 23:10 +0700, Ammar Faizi wrote:
> On 6/28/22 10:04 PM, Dylan Yudaken wrote:
> > copy from include/uapi/linux/io_uring.h
> >
> > Signed-off-by: Dylan Yudaken <[email protected]>
> > ---
> > src/include/liburing/io_uring.h | 53 ++++++++++++++++++++++++----
> > -----
> > 1 file changed, 39 insertions(+), 14 deletions(-)
> >
> > diff --git a/src/include/liburing/io_uring.h
> > b/src/include/liburing/io_uring.h
> > index 2f391c9..1e5bdb3 100644
> > --- a/src/include/liburing/io_uring.h
> > +++ b/src/include/liburing/io_uring.h
> > @@ -10,10 +10,7 @@
> >
> > #include <linux/fs.h>
> > #include <linux/types.h>
> > -
> > -#ifdef __cplusplus
> > -extern "C" {
> > -#endif
>
> Dylan,
>
> That `extern "C"` thing is for C++, we shouldn't omit it.
>
> Or better add that to the kernel tree as well, it won't break
> the kernel because we have a __cplusplus guard here.
>
> Jens what do you think?
>
> Just for reference, that line is introduced in commit:
>
> commit 3d74c677c45eccf36b92f7ad4b3317adc1ed06bb
> Author: Bart Van Assche <[email protected]>
> Date: Sun Jun 28 12:58:19 2020 -0700
>
> Make the liburing header files again compatible with C++
>
> Include <atomic> instead of <stdatomic.h> if built with a C++ compiler.
>
> Fixes: b9c0bf79aa87 ("src/include/liburing/barrier.h: Use C11 atomics")
> Signed-off-by: Bart Van Assche <[email protected]>
> Signed-off-by: Jens Axboe <[email protected]>
>
> src/include/liburing.h | 8 ++++----
> src/include/liburing/barrier.h | 37 +++++++++++++++++++++++++++++++++++--
> src/include/liburing/io_uring.h | 8 ++++++++
> 3 files changed, 47 insertions(+), 6 deletions(-)
>
> Adding the author to the CC list.
>
Yeah this makes sense. I think I just assumed the file was a manual
copy of the latest kernel one which it clearly is not.
I'll fix it up in v2
next prev parent reply other threads:[~2022-06-28 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 15:04 [PATCH liburing 0/4] liburing: multishot receive Dylan Yudaken
2022-06-28 15:04 ` [PATCH liburing 1/4] add t_create_socket_pair Dylan Yudaken
2022-06-28 15:04 ` [PATCH liburing 2/4] add IORING_RECV_MULTISHOT to io_uring.h Dylan Yudaken
2022-06-28 16:10 ` Ammar Faizi
2022-06-28 16:12 ` Jens Axboe
2022-06-28 16:12 ` Dylan Yudaken [this message]
2022-06-28 16:12 ` Dylan Yudaken
2022-06-28 15:04 ` [PATCH liburing 3/4] add recv-multishot test Dylan Yudaken
2022-06-28 15:04 ` [PATCH liburing 4/4] add IORING_RECV_MULTISHOT docs Dylan Yudaken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a015d366fbd061e158b8829c29f9e101e54cb1ff.camel@fb.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox