Re: [PATCH v1 2/2] Allow custom MySQL port from the env file

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 25/12/2022 05.00, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> 
> I don't always use 3306 as the MySQL server port. Allow custom port
> to be configured from the env file!
> 
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---
>   
> +	port = os.getenv("DB_PORT")
> +	if not port:
> +		port = 3306
> +	else:
> +		port = int(port)
> +
>   	client = GWClient(
>   		db_conn=connector.connect(
>   			host=os.getenv("DB_HOST"),
>   			user=os.getenv("DB_USER"),
> +			port=port,
>   			password=os.getenv("DB_PASS"),
>   			database=os.getenv("DB_NAME")
>   		),

This code can be shorten to:
	client = GWClient(
		db_conn=connector.connect(
			host=os.getenv("DB_HOST"),
			user=os.getenv("DB_USER"),
			port=int(os.environ.get("DB_PORT", 3306)),
			password=os.getenv("DB_PASS"),
			database=os.getenv("DB_NAME")
		)

`os.environ` here is a dict object, a dict object has a .get() function,
the second argument of the .get() is a default return if the first 
argument (dict key) is not exist. Like, DB_PORT is not exist in dict 
keys, then it will return 3306.

>   
> +	port = os.getenv("DB_PORT")
> +	if not port:
> +		port = 3306
> +	else:
> +		port = int(port)
> +
>   	client = DaemonClient(
>   		"telegram/storage/EmailScraper",
>   		api_id=int(os.getenv("API_ID")),
> @@ -30,6 +36,7 @@ def main():
>   		conn=connector.connect(
>   			host=os.getenv("DB_HOST"),
>   			user=os.getenv("DB_USER"),
> +			port=port,
>   			password=os.getenv("DB_PASS"),
>   			database=os.getenv("DB_NAME")
>   		),

Implement this too.