GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
From: Kiizuha <[email protected]>
To: Ammar Faizi <[email protected]>,
	Alviro Iskandar Setiawan <[email protected]>,
	Muhammad Rizki <[email protected]>
Cc: GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v3 04/17] fix: utils: Fix the extract_list() utility function
Date: Tue, 20 Dec 2022 08:53:44 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 20/12/2022 07.45, Ammar Faizi wrote:
> On 12/20/22 7:33 AM, Alviro Iskandar Setiawan wrote:
>> On Tue, Dec 20, 2022 at 6:57 AM Muhammad Rizki <[email protected]> 
>> wrote:
>>> +def extract_list(key: str, thread: Message):
>>> +       try:
>>> +               people = thread.get(key.lower())
>>> +               if not people:
>>> +                       return []
>>> +       except:
>>>                  return []
>>>          return __extract_list(people)
>>
>> Why does this have to be a "try and except"?
>> And not something like:
>>
>>          k = key.lower()
>>          if k in thread:
>>                  return __extract_list(people)
>>          return []
> 
> I don't know much about Python, but doesn't that only
> work for dict? Or it can use `in` operator too?

Message class has its own `get()` function.

> 
> `thread` is an instance of Message class object here.
> 

That's right, but if you use it like `str(thread)` it will return a full 
email content like email headers and email body.

  parent reply	other threads:[~2022-12-20  1:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 23:57 [PATCH v3 00/17] RESEND: Fix, improvement and implement a bot logger Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 01/17] discord: Fix typo on _flood_exception() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 02/17] fix: utils: Fix .patch file payload Muhammad Rizki
2022-12-20  0:15   ` Alviro Iskandar Setiawan
2022-12-20  0:18     ` Kiizuha
2022-12-19 23:57 ` [PATCH v3 03/17] fix: utils: add a substr for the patch media caption Muhammad Rizki
2022-12-20  0:29   ` Alviro Iskandar Setiawan
2022-12-20  1:59     ` Kiizuha
2022-12-20  8:13       ` Alviro Iskandar Setiawan
2022-12-19 23:57 ` [PATCH v3 04/17] fix: utils: Fix the extract_list() utility function Muhammad Rizki
2022-12-20  0:33   ` Alviro Iskandar Setiawan
2022-12-20  0:45     ` Ammar Faizi
2022-12-20  1:15       ` Alviro Iskandar Setiawan
2022-12-20  1:56         ` Kiizuha
2022-12-20  1:53       ` Kiizuha [this message]
2022-12-20  1:51     ` Kiizuha
2022-12-20  8:15       ` Alviro Iskandar Setiawan
2022-12-19 23:57 ` [PATCH v3 05/17] utils: Back to use decode=True for the get_payload() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 06/17] utils: Improve fix_utf8_char() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 07/17] utils: Add catch_err() for the log message Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 08/17] logger: Initial work for the bot logger for future use Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 09/17] telegram: Use the created BotLogger() class Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 10/17] telegram: Add variable LOG_CHANNEL_ID declaration Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 11/17] telegram: Add send_log_file() in the DaemonClient() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 12/17] telegram: Implement the log message for catching errors Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 13/17] discord: Add variable LOG_CHANNEL_ID declaration Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 14/17] discord: Use the BotLogger() to the GWClient() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 15/17] discord: Add send_log_file in " Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 16/17] discord: Implement the catch erros and logs Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 17/17] Remove some unused imports Muhammad Rizki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox