From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1693730382; bh=yxkc19Yddxx2lm9hSObkxc16S8ET0C2EW0xu5EssMEM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=FlzrZxbQ6JBLaz00gEXjXI50hWB7NUPkxoiuOxH98CecURVCxyz5lHje2uzTsL+vg HPONEPB6ID7wTv++XVQV24VAnKxhEGi5RLz204E0onrAld7CoxmQ/iLLSoJX9UMqWv F2ujWkfRCh6Ab6YNTkb/VWgb8J7qmsUV46uSKTY1C6w0Xb+KTCobd179qD2hUKSZ1b StUcDdDGVLMyEZJL/p5r1mpKX2R1lQtnhfSuOgyu+PHLI6FDJd1I5l/Unz8L23dfPg ECw/U7FHOeqD3pgiqlEk9xWPpjY9k/gMHy1d+y/LYtTyV6Wjf1lI8x1/qoX0nXdmr6 9xjntut/TxVKg== Received: from [10.20.0.2] (unknown [182.253.126.208]) by gnuweeb.org (Postfix) with ESMTPSA id 35E9024B3E1; Sun, 3 Sep 2023 15:39:38 +0700 (WIB) Message-ID: Date: Sun, 3 Sep 2023 15:39:33 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v3 2/4] tools/nolibc: x86-64: Use `rep stosb` for `memset()` Content-Language: en-US To: Willy Tarreau Cc: Alviro Iskandar Setiawan , =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , David Laight , Nicholas Rosenberg , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List References: <20230902133505.2176434-1-ammarfaizi2@gnuweeb.org> <20230902133505.2176434-3-ammarfaizi2@gnuweeb.org> From: Ammar Faizi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: [ Resend, I sent it using the wrong From address. ] On 2023/09/03 午後3:17, Willy Tarreau wrote: > On Sun, Sep 03, 2023 at 02:34:22AM +0700, Ammar Faizi wrote: >> On Sun, Sep 03, 2023 at 02:28:18AM +0700, Alviro Iskandar Setiawan wrote: >>> nit: Be consistent. Use \n\t for the memset too. >> >> Good catch, I'll fix that in v4 revision. > > Ammar, I'm overall fine with your series. I can as well add the missing \t > to your patch while merging it, or wait for your v4, just let me know. I'm now traveling and will be available in Jakarta on Monday. Thus, I actually planned to send the v4 revision on Monday. However, since you don't have further objections to this series, I'll leave the trivial missing bit to you. Please merge this series and I will not send a v4 revision. Thanks, -- Ammar Faizi