Re: [PATCH] slc: Fix file descriptor leak

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 6/6/22 9:27 AM, Ammar Faizi wrote:
> Arthur Lapz reported that he is seeing a blocking socket from the
> public client side after the app side has closed the connection.
> 
> This turned out that we haven't closed the SLC socket file descriptor:
> 
> ```
>       Isolated                              Server
>       --------                              ------
> 
>        fd_app --                         -- fd_public_client
>                 |----[ SLC circuit ]----|
>    fd_circuit --                         -- fd_circuit
> 
> ```
> After the app in the isolated client has closed its fd, we didn't close
> the fd_app and fd_circuit. That's why the server is still sleeping,
> waiting for any response from the isolated area.
> 
> This was just a typo in if statements that caused the close() paths were
> not taken. Simply fix the typo. Change "==" to "!=".
> 
> Link: https://t.me/lostcontrol_s1/16737
> Link: https://t.me/lostcontrol_s1/16739 # Reproducer
> Fixes: 04a86adffa415e8365d27929bbb826028e00bfd3 ("Initial commit")
> Reported-by: Arthur Lapz <rlapz@gnuweeb.org>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---

@rlapz, can you test this patch and see if it's a cure?

-- 
Ammar Faizi