From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.3] (unknown [101.128.125.55])
	by gnuweeb.org (Postfix) with ESMTPSA id 6447781663;
	Sun, 20 Nov 2022 06:39:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1668926381;
	bh=zL+GrAJcd950KxRt2WI4fUzEYvFrCXrIv4cDekpGIIY=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=qVCZU5GjDIAWrO53nVmaL8be2GHo2j9DfzZ6fnfgabvc1yTK3LByJixyRdZCNVmWN
	 szpCdkGQgDZqi3W7QAARkAmx6fgomcon+IBmoa8Gf5fv4RdNltZIzEzXj3HI9ahLS0
	 SH88C0XMnprGuj2o771h8HsRc5D1fb+qhyZs/KODFK8whGlMF8msVEO7vHlN2vH2s/
	 pTde6Z6F5LeexWACtRJX3eorMXwXNaUGCj4s0siiTTyhJjxNAySd66gChTCIK9+r1m
	 UNz20GXndZf6hq6k61IpKvgWYuYoCSZDTpymqK3qXA9XmDVnVnUR3y2mQMWsAqw5NK
	 25xP9PAWXQwXQ==
Message-ID: <a9050760-10c3-5f37-7f50-fa1442fd3ed5@gnuweeb.org>
Date: Sun, 20 Nov 2022 13:39:36 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 02/17] fix: utils: Fix .patch file payload
Content-Language: en-US
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221109025002.258-1-kiizuha@gnuweeb.org>
 <20221109025002.258-3-kiizuha@gnuweeb.org>
 <01cb31ca-f1f7-f67d-4bc9-04a392afee13@gnuweeb.org>
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <01cb31ca-f1f7-f67d-4bc9-04a392afee13@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <gwml.vger.gnuweeb.org>

On 20/11/2022 11.49, Ammar Faizi wrote:
> On 11/9/22 9:49 AM, Muhammad Rizki wrote:
>>  From the previous version 59d20af, the .patch file payload uses the
>> prepare_patch() `text` parameter that taken from the create_template()
>> `caption` returned which is the caption is already trimmed. With the
>> current fix, this should be use the full email payload instead so its
>> not bothering with the trimmed payload from the create_template().
> 
> I don't understand what you are talking about. Please fix your wording.
> 

In the old patch, the *.patch file contents are come from the 
prepare_patch()'s text argument, which is the `text` itself are taken 
from the `caption` returned from the create_template().

Code flow example:
     	caption, files, is_patch = create_template()
     	tmp, doc, caption, url = utils.prepare_patch(caption)
	# see mailer/listener.py in each bots for more details.

As I said above, the *.patch contents are using from the 
create_template()'s caption which is already trimmed to limit the 
caption for each bots. In this patch, I change it to use email payload 
instead. Is that clear?