From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v1 1/3] dnslookup: split common functionality and struct into net.c
Date: Thu, 31 Jul 2025 21:01:02 +0700 [thread overview]
Message-ID: <aIt3HtoUsnYc6Iup@linux.gnuweeb.org> (raw)
In-Reply-To: <20250731030856.366368-2-reyuki@gnuweeb.org>
On Thu, Jul 31, 2025 at 10:07:44AM +0700, Ahmad Gani wrote:
> +int init_addr(const char *addr, struct gwp_sockaddr *addr_st, uint16_t port)
This is a no-no. We don't need it.
In gwproxy.c, there is convert_str_to_ssaddr(). It's also better than
your version because with it you can have:
./gwproxy --target google.com:80 --bind localhost:1111
Not restricted to IP address format, but domain name is also ok.
--
Ammar Faizi
next prev parent reply other threads:[~2025-07-31 14:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 3:07 [PATCH gwproxy v1 0/3] Initial work for DNS lookup implementation Ahmad Gani
2025-07-31 3:07 ` [PATCH gwproxy v1 1/3] dnslookup: split common functionality and struct into net.c Ahmad Gani
2025-07-31 14:01 ` Ammar Faizi [this message]
2025-07-31 18:28 ` Alviro Iskandar Setiawan
2025-07-31 18:36 ` Ammar Faizi
2025-07-31 18:42 ` Alviro Iskandar Setiawan
2025-07-31 18:53 ` Ammar Faizi
2025-07-31 19:03 ` Alviro Iskandar Setiawan
2025-07-31 3:07 ` [PATCH gwproxy v1 2/3] dnslookup: Allow only port string number Ahmad Gani
2025-07-31 3:07 ` [PATCH gwproxy v1 3/3] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function Ahmad Gani
2025-07-31 18:19 ` Alviro Iskandar Setiawan
2025-07-31 19:14 ` Alviro Iskandar Setiawan
2025-08-01 1:51 ` reyuki
2025-08-01 23:32 ` Alviro Iskandar Setiawan
2025-07-31 13:39 ` [PATCH gwproxy v1 0/3] Initial work for DNS lookup implementation Ammar Faizi
2025-08-01 1:49 ` reyuki
2025-08-01 2:19 ` Ammar Faizi
2025-08-05 6:28 ` reyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIt3HtoUsnYc6Iup@linux.gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox