From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1753970467;
	bh=SCBwMjwfPmtYU6YgP5+AuemSM2pdrefDDrXR9jXKAJU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:In-Reply-To:Message-ID:Date:From:Reply-To:Subject:To:
	 Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To:
	 Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding;
	b=bLdACDKGiw547CsQ1ZXBM9sU3VJ+PWjAiTf/sr0kqD/PrkAKVQ2kKLwnwC4iR6Qkq
	 3GPrBbC78A+30WNk41N/U98nNQn2cFnNQKjkNoESBDQ56lOslCm5mCwla7vdNNis3m
	 zRGLr1Bm30AhDFbUy7NxJY1Cgh9X2kzuA/E8N8ve/ybJmRrHX/toTDTo+FDiG3l7L1
	 2NZUXgsQuctKOZ6wA+3HF4NODCwae83s/okwSLAXoVoDOUPjR68tToCL2NipL+5wKn
	 76A7q/Yg0g3yGdpHfhTcm5xJzxBzMDPOXoShnNo/0kHOcQFLehag4LtwtR+ua1JYZ/
	 JIfH8XiXLk8Cg==
Received: from linux.gnuweeb.org (unknown [182.253.126.229])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 6BA903126E19;
	Thu, 31 Jul 2025 14:01:06 +0000 (UTC)
Date: Thu, 31 Jul 2025 21:01:02 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v1 1/3] dnslookup: split common functionality and
 struct into net.c
Message-ID: <aIt3HtoUsnYc6Iup@linux.gnuweeb.org>
References: <20250731030856.366368-1-reyuki@gnuweeb.org>
 <20250731030856.366368-2-reyuki@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250731030856.366368-2-reyuki@gnuweeb.org>
X-Machine-Hash: hUx9VaHkTWcLO7S8CQCslj6OzqBx2hfLChRz45nPESx5VSB/xuJQVOKOB1zSXE3yc9ntP27bV1M1
List-Id: <gwml.vger.gnuweeb.org>

On Thu, Jul 31, 2025 at 10:07:44AM +0700, Ahmad Gani wrote:
> +int init_addr(const char *addr, struct gwp_sockaddr *addr_st, uint16_t port)

This is a no-no. We don't need it.

In gwproxy.c, there is convert_str_to_ssaddr(). It's also better than
your version because with it you can have:

  ./gwproxy --target google.com:80 --bind localhost:1111

Not restricted to IP address format, but domain name is also ok.

-- 
Ammar Faizi