From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754386010; bh=DqNx7JEYf3UgO2eLeRPYmD1MEjQYg0YaEEbRaQEJNUE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To:Message-ID:Date:From:Reply-To:Subject:To: Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To: Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding; b=EPphF5/GdYmAIU3L1FbDnEUU0MXJ7t1KfYqkEAwUfmYwvpGFJwn7YRDZNwByK0yNp LVhOIQUqVwMxnCcvHQvBxtDbh1PurcFcfq3uHJVK3/Z76cxd2x9zPp8hWjtjzXHucC LOpjAMlu33p38zxm2DadEERELh2/JiiVvKmC3uwgscfx+JWwiG15aE45uWbeceROdz LFocdyto8vFQfs6bIhy30jufRzHZgI2Ywza4aTnEpO2hkZ/SQ9/dVVbPyCVi1KYFgZ W2MXIKDvZA/SASjNcIntGb9GO09Ho3QFSSXk+1HwKskIsxd9ngAZ2Qfrj/6rDArpKP dj0kdyTHkgJww== Received: from linux.gnuweeb.org (unknown [182.253.126.229]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 6D6233128035; Tue, 5 Aug 2025 09:26:49 +0000 (UTC) Date: Tue, 5 Aug 2025 16:26:46 +0700 From: Ammar Faizi To: Ahmad Gani Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List Subject: Re: [PATCH gwproxy v3 6/9] dnsparser: Fix serialize_answ function Message-ID: References: <20250805064933.109080-1-reyuki@gnuweeb.org> <20250805064933.109080-7-reyuki@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250805064933.109080-7-reyuki@gnuweeb.org> X-Machine-Hash: hUx9VaHkTWcLO7S8CQCslj6OzqBx2hfLChRz45nPESx5VSB/xuJQVOKOB1zSXE3yc9ntP27bV1M1 List-Id: On Tue, Aug 05, 2025 at 01:49:26PM +0700, Ahmad Gani wrote: > This changes ensure memory read access is always valid. It fixes a logic > bug in serialize_answ that can lead to a memory error: invalid read. Don't add a new patch that fixes a bug to your previous patch in the same series. Each patch, when applied, must not introduce a known bug. This hurts bisectability. This fix should be squashed into the buggy patch. -- Ammar Faizi