From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Simon Horman <horms@kernel.org>
Cc: Oliver Neukum <oneukum@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Netdev Mailing List <netdev@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Armando Budianto <sprite@gnuweeb.org>,
gwml@vger.gnuweeb.org, stable@vger.kernel.org,
John Ernberg <john.ernberg@actia.se>
Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement
Date: Wed, 6 Aug 2025 04:16:24 +0700 [thread overview]
Message-ID: <aJJ0qKopqPg38dMG@linux.gnuweeb.org> (raw)
In-Reply-To: <20250805202848.GC61519@horms.kernel.org>
On Tue, Aug 05, 2025 at 09:28:48PM +0100, Simon Horman wrote:
> It seems this has escalated a bit as it broke things for Linus while
> he was travelling. He tested this patch and it resolved the problem.
> Which I think counts for something.
>
> https://lore.kernel.org/netdev/CAHk-=wgkvNuGCDUMMs9bW9Mz5o=LcMhcDK_b2ThO6_T7cquoEQ@mail.gmail.com/
>
> I have looked over the patch and it appears to me that it addresses a
> straightforward logic error: a check was added to turn the carrier on only
> if it is already on. Which seems a bit nonsensical. And presumably the
> intention was to add the check for the opposite case.
>
> This patch addresses that problem.
>
> So let me try and nudge this on a bit by providing a tag.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Hi Linus,
Given that Reviewed-by tag and the simplicity of the patch, it would be
great if you can take this patch sooner to your tree. The fix is very
critical for network connectivity. Especially for laptop users.
https://lore.kernel.org/all/20250801190310.58443-1-ammarfaizi2@gnuweeb.org/
--
Ammar Faizi
next prev parent reply other threads:[~2025-08-05 21:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 19:03 [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement Ammar Faizi
2025-08-04 10:00 ` Simon Horman
2025-08-05 20:28 ` Simon Horman
2025-08-05 21:16 ` Ammar Faizi [this message]
2025-08-05 22:40 ` Linus Torvalds
2025-08-05 23:47 ` Jakub Kicinski
2025-08-05 23:57 ` Ammar Faizi
2025-08-12 20:57 ` John Ernberg
2025-08-05 23:56 ` Ammar Faizi
2025-08-06 0:05 ` Ammar Faizi
2025-08-06 1:11 ` Linus Torvalds
2025-08-06 1:54 ` Linus Torvalds
2025-08-07 1:37 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJJ0qKopqPg38dMG@linux.gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwml@vger.gnuweeb.org \
--cc=horms@kernel.org \
--cc=john.ernberg@actia.se \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=sprite@gnuweeb.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox