From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1754438735;
	bh=bj+RZzaHVNpoliwAGa9XYm5UNfnwharwglOw4U7Tgek=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:In-Reply-To:Message-ID:Date:From:Reply-To:Subject:To:
	 Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To:
	 Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding;
	b=DHMYWxAzEHmz4jrtg4O2K9dt+cvr7lk8rcZbxE7YxjADTg88lqrB0djeyOMu8zMbl
	 7QydPwCg4ew9mpGnnokAdOBscZ9CCVFk7mUlUVVL4pj/mv7IdmZc3FsS2VHCPseB02
	 mdEeOw0aeX1EG5pOH5zHWD2HbdQOBpPqtd2re1Si1JsAw7iIc87jDeG/XsmDEZlwJX
	 2GCMUGkDDoP7MyEY7QvLtC1gq52P8+0W+znBjcEKdnucdiWYMgmURuu/Q1aIVCrrT7
	 p9L90MNfz3R5WAA3t1FGqC44hyPwGQFSvs4516pCBVXMt6fvprekpkUO7bAUhLzIAV
	 E6wm0DosSW6kA==
Received: from linux.gnuweeb.org (unknown [182.253.126.229])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 3F29A3127C24;
	Wed,  6 Aug 2025 00:05:32 +0000 (UTC)
Date: Wed, 6 Aug 2025 07:05:29 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Simon Horman <horms@kernel.org>, Oliver Neukum <oneukum@suse.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Netdev Mailing List <netdev@vger.kernel.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Armando Budianto <sprite@gnuweeb.org>, gwml@vger.gnuweeb.org,
	stable@vger.kernel.org, John Ernberg <john.ernberg@actia.se>
Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on()
 call placement
Message-ID: <aJKcSZCirArmH2/c@linux.gnuweeb.org>
References: <20250801190310.58443-1-ammarfaizi2@gnuweeb.org>
 <20250804100050.GQ8494@horms.kernel.org>
 <20250805202848.GC61519@horms.kernel.org>
 <CAHk-=wjqL4uF0MG_c8+xHX1Vv8==sPYQrtzbdA3kzi96284nuQ@mail.gmail.com>
 <aJKaHfLteSF842IY@linux.gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aJKaHfLteSF842IY@linux.gnuweeb.org>
X-Machine-Hash: hUx9VaHkTWcLO7S8CQCslj6OzqBx2hfLChRz45nPESx5VSB/xuJQVOKOB1zSXE3yc9ntP27bV1M1
List-Id: <gwml.vger.gnuweeb.org>

On Wed, Aug 06, 2025 at 06:56:20AM +0700, Ammar Faizi wrote:
> Apart from moving it outside that if-statement, unlink_urbs() call
> should probably also be guarded as we agreed it makes no sense to call
> it when we're turning the link on.

Oh, no.

I just realized, it does need to be guarded because if netif_carrier_on()
is placed before the if (!netif_carrier_ok(dev->net)), it already clears
__LINK_STATE_NOCARRIER.

-- 
Ammar Faizi