From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754463839; bh=4KkiT8aTVUSr/YUQnVJEygBUv4qKSGIGNayt0JqU458=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To:Message-ID:Date:From:Reply-To:Subject:To: Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To: Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding; b=Pzv0lwvxMqKqMHcYpCvSBBzbH7YIkBsi1pYbdoKw2Y2nABUujyd0S1VFhBJbDqz9+ d1qBSyQBOGPYCDrIOOpzRTH58UNrIPkYh56RQjw6XJkCwcX4yrxNhowwB/JC4GJPPe GBJVF2gFvPdBXRg22lG3VLPqQVprIgUjyKVU0FxPVjlGuTwvujVQ9guiAZE1aTwL3w P8CHpZZV9RsEgCjxwe8A9dIhrQs8Yr3PBMALwXddzo0Hc4JU0rZOrOnV7kuyeLxXxj HBkBuB8/jG8VD3wznvfzJRrGjvIoG/Sr41WIrgwBopS9c+9fHrsPxu3dPZEgNXqAqp 0Gun0Nu5Gpv7A== Received: from linux.gnuweeb.org (unknown [182.253.126.229]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 822723127C3D; Wed, 6 Aug 2025 07:03:58 +0000 (UTC) Date: Wed, 6 Aug 2025 14:03:55 +0700 From: Ammar Faizi To: Ahmad Gani Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List Subject: Re: [PATCH gwproxy v4 0/6] Initial work for DNS lookup implementation Message-ID: References: <20250806035727.216702-1-reyuki@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250806035727.216702-1-reyuki@gnuweeb.org> X-Machine-Hash: hUx9VaHkTWcLO7S8CQCslj6OzqBx2hfLChRz45nPESx5VSB/xuJQVOKOB1zSXE3yc9ntP27bV1M1 List-Id: On Wed, Aug 06, 2025 at 10:57:18AM +0700, Ahmad Gani wrote: > Ahmad Gani (6): > dnslookup: Split common functionality and struct into net.h and net.c > dnslookup: Add a new parameter default_port > dnslookup: Allow only port string number > dnslookup: Initial work for implementation of C-ares-like getaddrinfo > function > dnsparser: Transaction id creation is delegated to caller > dnslookup: Make gw_ares_getaddrinfo asynchronous Please don't leave trailing whitespaces. Patch #4 and patch #6 are dirty. -------- dnslookup: Initial work for implementation of C-ares-like getaddrinfo function .git/rebase-apply/patch:68: trailing whitespace. /* .git/rebase-apply/patch:326: trailing whitespace. * internal error can be interpreted as system call failure, .git/rebase-apply/patch:336: trailing whitespace. /* .git/rebase-apply/patch:359: trailing whitespace. * .git/rebase-apply/patch:381: trailing whitespace. /* warning: squelched 11 whitespace errors warning: 16 lines add whitespace errors. --------- dnslookup: Make gw_ares_getaddrinfo asynchronous .git/rebase-apply/patch:583: trailing whitespace. /* .git/rebase-apply/patch:656: trailing whitespace. * .git/rebase-apply/patch:663: trailing whitespace. * .git/rebase-apply/patch:668: trailing whitespace. * warning: 4 lines add whitespace errors. -- Ammar Faizi