From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1754470709;
	bh=6YouA5OM+xPilq6YQozlZ3FJDOCo4wfKeQj+xFkhkCs=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Transfer-Encoding:In-Reply-To:Message-ID:Date:
	 From:Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=DTCpPAr9Y2so8JVB3WGLSYPVqjmwPbZVaztoWw/rSkqr9UkbhlSB7xRlduSn4zAse
	 UdSBZZp8Pm1WNPsWHFUM+q/I6qQwuCuvmjd7MNAu2YHeQrvJgB0nwWWVvzYs1fQBAR
	 DLRui8v97PrCvhFfGRrjc/SOJysrWIfeI3wQZ5mEwk2fC4QHf5UGycbp8JPFFNMmY5
	 lLIK7fB2YlGObHqHz4vrK+bztkxZcGW6Jk5qJTVHyZprDMEYg/yIx3F8N8e6qc25+J
	 Pa0RQx3+Zt6oDah55rCEcgnz5WMG1ZP7xS0GSvSysU+4y9lBawZi5zqBSAn6zUA2i7
	 6s89iiY/VqFMw==
Received: from linux.gnuweeb.org (unknown [182.253.126.229])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id DD4D63127B0B;
	Wed,  6 Aug 2025 08:58:28 +0000 (UTC)
Date: Wed, 6 Aug 2025 15:58:25 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v4 0/6] Initial work for DNS lookup implementation
Message-ID: <aJMZMclvDLscCJLw@linux.gnuweeb.org>
References: <20250806035727.216702-1-reyuki@gnuweeb.org>
 <aJL/ZoudLLJ/ci1i@linux.gnuweeb.org>
 <CAADvAgoL0cFFCZcLxm+ngHuSFL_Z9M7jnwPD3oqt9nBy1Skv7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAADvAgoL0cFFCZcLxm+ngHuSFL_Z9M7jnwPD3oqt9nBy1Skv7g@mail.gmail.com>
X-Machine-Hash: hUx9VaHkTWcLO7S8CQCslj6OzqBx2hfLChRz45nPESx5VSB/xuJQVOKOB1zSXE3yc9ntP27bV1M1
List-Id: <gwml.vger.gnuweeb.org>

On Wed, Aug 06, 2025 at 03:37:15PM +0700, Ahmad Gani wrote:
> On Wed, Aug 6, 2025 at 2:08 PM Ammar Faizi wrote:
> > On Wed, Aug 06, 2025 at 10:57:18AM +0700, Ahmad Gani wrote:
> > >   dnslookup: Split common functionality and struct into net.h and net.c
> > >   dnslookup: Add a new parameter default_port
> >
> > I have applied these two patches as they're already in a good shape.
> > You can rebase on top of master branch.
> 
> Err... I made a small change to net.c, but it looks like the patch was
> already pulled. I just added a macro guard for _GNU_SOURCE to get rid of
> compiler warning about a macro constant being redeclared. What should I
> do in this case?

The CI build on GitHub didn't catch that warning. Not sure. It probably
missed -Werror flag on GitHub Actions, I'll take a look later. Still
cleaning my kitchen now...

You can send a follow up patch with a Fixes tag.

-- 
Ammar Faizi