Re: [PATCH gwproxy v4 0/6] Initial work for DNS lookup implementation

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On Wed, Aug 06, 2025 at 04:47:05PM +0700, Ammar Faizi wrote: 
> Yeah, it's missing -Werror flag on the CI, so it didn't fail. That warning
> actually exists:
> 
> x86_64-linux-gnu-gcc -ggdb3 -fvisibility=hidden -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-stack-protector -Wunsafe-loop-optimizations -Wstrict-aliasing=3 -Wstrict-prototypes -Wmissing-prototypes -Wstack-usage=8192 -Wformat -Wformat-security -Wformat-signedness -Wunreachable-code -Wsequence-point -Wextra -Wall -O2 -fpic -fPIC -D_GNU_SOURCE -include /home/runner/work/gwproxy/gwproxy/config.h -I./src/ -DNDEBUG -MMD -MP -MF src/gwproxy/ev/epoll.c.o.d -c src/gwproxy/ev/epoll.c -o src/gwproxy/ev/epoll.c.o
> src/gwproxy/net.c:1: warning: "_GNU_SOURCE" redefined
>     1 | #define _GNU_SOURCE
>       | 
> <command-line>: note: this is the location of the previous definition

I was a bit busy deep cleaning my house and had several video calls.

Now I am back to this CI thing, it turned out that when enabling
io_uring support, it breaks 32-bit architectures. This one is from
i686:
```
    src/gwproxy/ev/io_uring.c: In function ‘prep_timer_del_target’:
    src/gwproxy/ev/io_uring.c:327:56: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
      327 |         io_uring_prep_timeout_remove(s, EV_BIT_TIMER | (uint64_t)gcp, 0);
          |                                                        ^
    src/gwproxy/ev/io_uring.c: In function ‘handle_event’:
    src/gwproxy/ev/io_uring.c:773:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
      773 |         void *udata = (void *)CLEAR_EV_BIT(cqe->user_data);
          |                       ^
    In file included from ./src/gwproxy/gwproxy.h:15,
                    from ./src/gwproxy/ev/io_uring.h:8,
                    from src/gwproxy/ev/io_uring.c:11:
    src/gwproxy/ev/io_uring.c:857:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘int’ [-Werror=format=]
      857 |         pr_err(&ctx->lh, "Bug, invalid %s: res=%d, fd=%ld, s=%s", inv_op,
          |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      858 |                 cqe->res, (intptr_t)udata, strerror(-cqe->res));
          |                           ~~~~~~~~~~~~~~~
          |                           |
          |                           int
    ./src/gwproxy/log.h:40:41: note: in definition of macro ‘pr_log’
      40 |         __pr_log(__hd->handle, __level, FMT, ##__VA_ARGS__);    \
          |                                         ^~~
    src/gwproxy/ev/io_uring.c:857:9: note: in expansion of macro ‘pr_err’
      857 |         pr_err(&ctx->lh, "Bug, invalid %s: res=%d, fd=%ld, s=%s", inv_op,
          |         ^~~~~~
    src/gwproxy/ev/io_uring.c:857:57: note: format string is defined here
      857 |         pr_err(&ctx->lh, "Bug, invalid %s: res=%d, fd=%ld, s=%s", inv_op,
          |                                                       ~~^
          |                                                         |
          |                                                         long int
          |                                                       %d
```
Apparently this happens because a pointer size on 32-bit architectures
is 32-bit. We need double-casts to fix mess. I'll fix it.

-- 
Ammar Faizi