From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=j-ernberg-se.20230601.gappssmtp.com header.i=@j-ernberg-se.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=i16f9OVr; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 1C7DD3127EE7; Tue, 12 Aug 2025 20:57:59 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=none (p=none dis=none) header.from=j-ernberg.se Received-SPF: None (mailfrom) identity=mailfrom; client-ip=209.85.167.50; helo=mail-lf1-f50.google.com; envelope-from=j@j-ernberg.se; receiver= Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id 4C5EE3127EDF for ; Tue, 12 Aug 2025 20:57:58 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-55cbf9a78dbso4915117e87.2 for ; Tue, 12 Aug 2025 13:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-ernberg-se.20230601.gappssmtp.com; s=20230601; t=1755032277; x=1755637077; darn=vger.gnuweeb.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I1HYkWTm//0TzFaX3HirV9CEefr3/XfGLtwUTGZHPfw=; b=i16f9OVr9+FisMcn/stBII2uCjSfWxINFMKZiW2WRTy4OsacpLfxZfxcGrInM7TeKV BFNsPpBFJTHi9froFvzg2zBLhY15R12nPTix6s06ggE5QBECWgsvtPyPxoknYvGNHas9 QmqtLH9OtcxwyVeuTXT+egbyiolORDrTTWwy/8gTOk0p8QocwABnMgSUC9bmFKXkdhL4 vkDvS10/ZZmFKqkXIZk6JMKVKu1CyQt3+Kd5LMTmpVEbo/7P0SNcy9EcYvIwinC6x354 J+7gaUqFZpK929qdttqyz8f18z5muXue5moIKGErfGiClxYH8k8GrSFURTpgvkV1375P 8f7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755032277; x=1755637077; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I1HYkWTm//0TzFaX3HirV9CEefr3/XfGLtwUTGZHPfw=; b=pH3RBq494woJSb8D+8LrS4XvhZkyQjBnhql1yRdCnZwSJz6GJFkN3CQ/goeaQXKJhN Ku55+Eo2PtD+O+GIoay4lrSeB3RjFcIiwSmSaFx5PasElanknYBjJ/I+3bFBDZf6RU/M oDf3aTCL5zbQ/XUctkKoozwn04acjKmyvNwAftLJLHqcEKeIDDQPazc5Ra1u/O3+ARSY P53x+lRnbPdkIyu7GcuM0Yk8l9nfmx74uKTNL8VkuupHiw35rfOi67jad7jSglLHAN9Q qRRrn9UY7MYpFbf1Rkgj6gOTRGELPsRWrMiGVQrhTYIUJ4xShd3tCn6ykiK51XN5/V0h jwlw== X-Forwarded-Encrypted: i=1; AJvYcCXd+NLrYzeUr/H+gYTeC8MC2OF+/GZA9j56kf83uLtPsx/+4+7upb4UuPgTJGP8VAYObcRJ@vger.gnuweeb.org X-Gm-Message-State: AOJu0YxIcqGaNaFmTvUG2SxI+QcVo8PN1bEana3+mju7mhw91lp6r8Te YHxmKnNpB8w6oSStO+thcF+R5dv7GbBdfBDPPvtYwiBsvzHKQAdgDbIMiG4LQX2uv/A= X-Gm-Gg: ASbGnctAEBHRuQRzt8nGNQyXtrIoGV4+zHQR6t15QeoqsDgZoTniessY8tWh5Jqr0OQ fR1X+XEEKAWufzC62nZJUrlCH1A2OlYA7UFpgWKPEd5kEKYwlGb5NAWE+xK6NoPTMCiuFY6Hd+a 7CdWAO3WfyfxKeR68a+fsPITLcnBWJtcuXGBhJoEADYQwMmISUOy5Oc0dihqYxpGeQolduvwBe7 C3rxbKIDIqtxWtQxj+0BUJ2JitL7tgCTyJ+vxomXHbSxuy+0iAzkQ2nrGWZdG2Vmytbn0CJfV6u vcPZ1e/3H8vsv8X5jt3HIFmW9ZvtXnjmNQi2mx5amELf+TJI8Ww43sAVETbN+xvS4ZN0EBGlxhe znLGO+l81QJAIbyGGfVWj0IZYUuYd2u7wKBFF08pqzHs2sywIlw== X-Google-Smtp-Source: AGHT+IGffUI/1EXOSK/t0KV6xGplfLMgAAk2k7PICLXaMIAixPTAVPj1NMw1SVef+Ih1sVF86CbZxw== X-Received: by 2002:a05:6512:b12:b0:55a:4f05:6e4c with SMTP id 2adb3069b0e04-55ce0404609mr162441e87.49.1755032276914; Tue, 12 Aug 2025 13:57:56 -0700 (PDT) Received: from localhost (90-231-233-65-no2360.tbcn.telia.com. [90.231.233.65]) by smtp.gmail.com with UTF8SMTPSA id 2adb3069b0e04-55b88c990f1sm4946123e87.82.2025.08.12.13.57.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Aug 2025 13:57:56 -0700 (PDT) Date: Tue, 12 Aug 2025 22:57:55 +0200 From: John Ernberg To: Jakub Kicinski , Linus Torvalds , Ammar Faizi Cc: Simon Horman , Oliver Neukum , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Greg Kroah-Hartman , Linux Netdev Mailing List , Linux USB Mailing List , Linux Kernel Mailing List , Armando Budianto , gwml@vger.gnuweeb.org, stable@vger.kernel.org, John Ernberg Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement Message-ID: References: <20250801190310.58443-1-ammarfaizi2@gnuweeb.org> <20250804100050.GQ8494@horms.kernel.org> <20250805202848.GC61519@horms.kernel.org> <20250805164747.40e63f6d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250805164747.40e63f6d@kernel.org> List-Id: Hi Jakub, Linus, Ammar, (sorry for the delay, on vacation, wasn't paying attention to the internet) On Tue, Aug 05, 2025 at 04:47:47PM -0700, Jakub Kicinski wrote: > On Wed, 6 Aug 2025 01:40:37 +0300 Linus Torvalds wrote: > > So my gut feel is that the > > > > if (test_and_clear_bit(EVENT_LINK_CARRIER_ON, &dev->flags)) > > netif_carrier_on(dev->net); > > > > should actually be done outside that if-statement entirely, because it > > literally ends up changing the thing that if-statement is testing. > > Right. I think it should be before the if (!netif_carrier_ok(dev->net)) > > Ammar, could you retest and repost that, since we haven't heard from > John? I can't verify the suggested change until sometime in September, after I return to office, but it feels correct. However... I'm almost inclined to suggest a full revert of my patch as the testing was clearly royally botched. Booting it on the boards I have would have shown the failure immediately. (I did see v3 of this patch being applied) Apologies for the mess // John Ernberg