Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 10/28/22 4:21 PM, Alviro Iskandar Setiawan wrote:
> On Thu, Oct 27, 2022 at 10:08 PM Ammar Faizi wrote:
>> +       async def handle_db_error(self, e):
>> +               #
>> +               # TODO(ammarfaizi2):
>> +               # Ideally, we also want to log and report this situation.
>> +               #
>> +               print(f"Database error: {str(e)}")
>> +               print("Reconnecting to the database...")
>> +               self.db.connect()
>> +
>> +               #
>> +               # Don't do this too often, avoid connect() burst.
>> +               #
>> +               await asyncio.sleep(3)
> 
> What about sleeping first before connecting?
> As it'll give a chance for the server to start properly, MySQL server
> may take several seconds to restart.

ping(reconnect=True, attempts=3, delay=3) should handle this better.
I'll send a v2 later.

-- 
Ammar Faizi