Re: [PATCH liburing v3 0/4] Changes for Makefile

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 3/10/22 6:12 PM, Alviro Iskandar Setiawan wrote:
> Hello sir,
> 
> This patchset (v3) changes Makefile. 4 patches here:
> 
> 1. Remove -fomit-frame-pointer flag, because it's already covered
>     by the -O2 optimization flag.
> 
> 2. When the header files are modified, the compiled objects are
>     not going to be recompiled because the header files are not
>     marked as a dependency for the objects.
> 
>    - Instruct the compiler to generate dependency files.
> 
>    - Include those files from src/Makefile. Ensure if any changes are
>      made, files that depend on the changes are recompiled.
> 
> 3. The test binaries statically link liburing using liburing.a file.
>     When liburing.a is recompiled, make sure the tests are also
>     recompiled to ensure changes are applied to the test binary. It
>     makes "make clean" command optional when making changes.
> 
> 4. Same as no. 3, but for examples.
> 
> please review,
> thx

I think this series looks good.

-- 
Ammar Faizi