From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.3] (unknown [101.128.125.55])
	by gnuweeb.org (Postfix) with ESMTPSA id EFCB781663;
	Sun, 20 Nov 2022 06:26:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1668925594;
	bh=S2KhThpJualjFZGF67NYpBj8rA2oT5/My0Sf+Y2BLWg=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=J3N2KHxQWxeJwTyKzLrleFPrs1TnXyUPnFmvwb6esB+FGNy40XSAMpqV+tdDK2Fvy
	 3svQ103PhPSZvE00gvbxSD2cNskVRZDpsE6XUcnp9JIDm/60JQr3jszTI39/hO3Xr1
	 ps8uEDTegPOE8JmpsD4IOk/il1TmXU8i4NNizy7e0vkzf9gi+OT4uXVAsi6Z1n9LBZ
	 HMfnujUfafpHjOc2b1JYy5RFxMPtzeUzJz+zsAgLF+bKmEagQr8CP/UFkp572RLD18
	 X0ebfAYm9j7z3ORUz14WutjVhtn8kGMru5+Osw/6alJOvPKAipqnlmaL3vclWxqN+m
	 TLYrjk7MWQx7g==
Message-ID: <b0c0f901-6349-7056-e1cb-c0ee797e6851@gnuweeb.org>
Date: Sun, 20 Nov 2022 13:26:27 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 10/17] telegram: Add variable LOG_CHANNEL_ID
 declaration
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221109025002.258-1-kiizuha@gnuweeb.org>
 <20221109025002.258-11-kiizuha@gnuweeb.org>
 <805d11ed-cd4e-3c2f-9145-7d4e29175c5a@gnuweeb.org>
Content-Language: en-US
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <805d11ed-cd4e-3c2f-9145-7d4e29175c5a@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 20/11/2022 11.56, Ammar Faizi wrote:
> On 11/9/22 9:49 AM, Muhammad Rizki wrote:
>> Declare a variable LOG_CHANNEL_ID in the config.py.example for the
>> send_log_file() in the next commit.
>>
>> Signed-off-by: Muhammad Rizki <kiizuha@gnuweeb.org>
> 
> I really don't understand why are we keep using .env file if we have
> config.py. I want you to get rid of the env file and use the config.py
> only. Unless you can give me a reasonable answer of why we are using
> both of them.
> 

I used to using .env file instead of using config.py. Since you asked to 
declare a variable in the config.py (or something git-ignored) I just 
created config.py instead of keeping it in the .env file. But I just to 
remind you, if we want to use only 1 file config between config.py or 
.env will be a minor version change, choosing between config.py or .env 
file in this patch series are not related for me. Next patch series will 
be good if you agree.

You've to choose it so I can clearly what we needed, using the .env and 
load them in each bots main file and call them using 
`os.getenv("ENV_VAR")` or using the config.py and import it in each file 
we want to get LOG_CHANNEL_ID.