From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.2] (unknown [101.128.126.183])
	by gnuweeb.org (Postfix) with ESMTPSA id 24B8A804D1;
	Fri, 28 Oct 2022 19:46:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1666986365;
	bh=8gOh7JOWJcMCyN2ZFSYGQ09wE8VzfMczOfCBII/8Fuw=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=TcOnDtdXiGtg9RX2hROIDxSFfdyWYQEvbrGv5/EhbARAftCfm/JccHdLsXV7vamMw
	 PBPsLXBAJx57HNN8IbrCg8eJ2AR8F2GFUazP9q3bzpQ0vpLYfBzm787TOMeWpAN+rJ
	 x7N7L4Gq7fPbBJ9sJUPSjf/wfPb6L3ztgm/56oxXrewl39o7ega4zV3adbhzFALtqp
	 tsUbWh1VJP0l/iQJODZ0eDb2bATuJ1ZJC3qJ5SuYrLC4zDKXlLtKlBrY4aKiDUVgVO
	 ud360yc/BNCHrHge9DwoJZ8wRGDMWjougHE1YJf7UT0NpedLBsS27+woR7bsS5M7Ma
	 InBKctpxIXc0w==
Message-ID: <b44fb434-01be-bfd3-76d7-75e0a6308be6@gnuweeb.org>
Date: Sat, 29 Oct 2022 02:46:01 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error
Content-Language: en-US
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221027150823.601914-1-ammarfaizi2@gnuweeb.org>
 <20221027150823.601914-3-ammarfaizi2@gnuweeb.org>
 <CAOG64qN9BZcnz1px8tAj9_Y96FhU1nVMOA58rfs-4nRY6GhWAg@mail.gmail.com>
 <1d500d37-b11b-75fd-38e5-d7f8e0a9b1d4@gnuweeb.org>
 <CAOG64qO8c4gE=HmL-1QQkqenD+T4ezsU=+FCGsth59=CFjyKpw@mail.gmail.com>
 <3a79a587-ddee-9e25-2ac5-b573938b44a9@gnuweeb.org>
 <043f55c3-67d8-9130-aca4-73c59926d2af@gnuweeb.org>
 <CAOG64qNSS6S0geOHHi50Z_sW5ymW4Cb5=JYt5VO3=4-jjh2KhQ@mail.gmail.com>
 <63aa1b63-f7e2-8da3-b16d-0c7e1045d697@gnuweeb.org>
 <CAOG64qOoL3knPRTVcX+jOopt+24vE0C39Y0Jf1-YAnbGhG7LFQ@mail.gmail.com>
 <9ecfe8ab-fa5a-d01a-0b68-bc639f14888f@gnuweeb.org>
 <CAOG64qNBTV1YnckBPtscLp7LGZ+75fwF58VwBCN5U=ue3D_HaA@mail.gmail.com>
 <54c6d514-f8b3-f8bc-f98b-28a1400fac84@gnuweeb.org>
 <CAOG64qPjgf0Yuh90CV-sn8hTra09Xi_mOuUVf_0S_yYjuifS0A@mail.gmail.com>
 <0dc84729-cd72-0ed2-2e99-6aaa90557af9@gnuweeb.org>
 <CAOG64qPfbtof1t3G7cRzbKNCRc=kXjNiyLrrE2xpUGKvKKnMvw@mail.gmail.com>
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <CAOG64qPfbtof1t3G7cRzbKNCRc=kXjNiyLrrE2xpUGKvKKnMvw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 29/10/22 02.44, Alviro Iskandar Setiawan wrote:
> On Sat, Oct 29, 2022 at 2:39 AM Muhammad Rizki wrote:
>> Which function?
> 
> remove_patch().
> 
>> if __send_mail() yeah it only once called, the
>> remove_patch() doesn't called once.
> 
> That's literally a hole. The problem is remove_patch() may be called
> asynchronously together with a job that doesn't hold the mutex.
> 
>    - job_a is still using the file
>    - job_b doesn't know anything about job_a, but it removes all files
> blindly. job_b doesn't know anything about mutex in job_a.
> 
> -- Viro

So, you are talking about calling a remote_patch() all together if 
doesn't hold it with mutex?