From: Ammar Faizi <[email protected]>
To: Muhammad Rizki <[email protected]>
Cc: GNU/Weeb Mailing List <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>
Subject: Re: [PATCH v2 0/3] New Discord bot and full refactor scripts
Date: Sat, 3 Sep 2022 08:28:56 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/27/22 10:02 AM, Muhammad Rizki wrote:
> Muhammad Rizki (3):
> Move the Telegram bot source code
> First release Discord bot
> Full refactor bot scripts
Please split these into smaller manageable-reviewable pieces.
I simply can't review it. Each patch should only do one thing.
This it too big to review.
For example, something like this:
Patch #1: daemon: telegram: Move telegram bot source code
Patch #2: daemon: discord: Initial Discord bot MySQL table
Patch #3: daemon: telegram: Adjust table naming with Discord
Patch #4: daemon: discord: Initial Discord bot core (python)
Patch #5: daemon: discord: Add feature AAAAAA
Patch #6: daemon: discord: Add feature BBBBBB
Patch #7: daemon: discord: Add feature CCCCCC
... and so on
I want something like that or whatever reviewable. Not this huge
diff doing everything in a single patch. This series is crazy and
can't be reviewed.
--
Ammar Faizi
next prev parent reply other threads:[~2022-09-03 1:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 3:02 [PATCH v2 0/3] New Discord bot and full refactor scripts Muhammad Rizki
2022-08-27 3:02 ` [PATCH v2 1/3] Move the Telegram bot source code Muhammad Rizki
2022-08-27 3:02 ` [PATCH v2 2/3] First release Discord bot Muhammad Rizki
2022-09-03 0:29 ` Ammar Faizi
2022-08-27 3:02 ` [PATCH v2 3/3] Full refactor bot scripts Muhammad Rizki
2022-08-27 10:40 ` [PATCH v2 0/3] New Discord bot and full refactor scripts Ammar Faizi
2022-08-27 16:00 ` Muhammad Rizki
2022-08-29 3:39 ` Ammar Faizi
2022-09-03 0:42 ` Ammar Faizi
2022-09-03 0:45 ` Ammar Faizi
2022-09-03 1:01 ` Muhammad Rizki
2022-09-03 9:44 ` Ammar Faizi
2022-09-03 9:46 ` Ammar Faizi
2022-09-03 10:05 ` Muhammad Rizki
2022-09-03 10:32 ` Ammar Faizi
2022-09-03 10:34 ` Ammar Faizi
2022-09-03 10:40 ` Ammar Faizi
2022-09-03 10:58 ` Muhammad Rizki
2022-09-03 10:52 ` Muhammad Rizki
2022-09-03 10:43 ` Muhammad Rizki
2022-09-03 0:56 ` Muhammad Rizki
2022-09-03 1:00 ` Ammar Faizi
2022-09-03 0:29 ` Ammar Faizi
2022-09-03 1:28 ` Ammar Faizi [this message]
2022-09-03 3:09 ` Muhammad Rizki
2022-09-03 9:56 ` Alviro Iskandar Setiawan
2022-09-03 9:58 ` Ammar Faizi
2022-09-03 10:06 ` Alviro Iskandar Setiawan
2022-09-03 10:12 ` Ammar Faizi
2022-09-03 10:43 ` Alviro Iskandar Setiawan
2022-09-03 11:09 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox