From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.230.80] (unknown [182.2.70.226]) by gnuweeb.org (Postfix) with ESMTPSA id 26A967E3B9; Sat, 3 Sep 2022 01:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662168541; bh=EvVHc2vdBd9ObpMluToxPDBRsrQf/Sae3HlUa5YEv6s=; h=Date:To:Cc:References:From:Subject:In-Reply-To:From; b=i2ugfJLDpUZHDSuZ6nU4b+M8jWXRAR7dmTlo+yKU7YIN/XE21dbnllyb0+DK9ZUo4 4yqfcKWLOYo90R+4BpBz67EuzI0IouqR03pN+Zz/raA2rfxJbPuVyAgO4v3JqBPRQR X7gRMOeRmDhY96r1A7AKwzT2doXgMQyrcefFkeefv0jkXtGfFXWVjHD2e/V95UKJbR jjpbacUaLdRC381BVx1mHeqLtvhskAALuSL4ZTJQeRClRdpH+dSvefOeZZoH2gCOX/ pvc5+CbQwtxtr9IVARfy2h/ESA851kZnGqdZ7hpIiLuzVoNah8BujXpLnDBzxswPz2 m559xciEJInPA== Message-ID: Date: Sat, 3 Sep 2022 08:28:56 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Muhammad Rizki Cc: GNU/Weeb Mailing List , Alviro Iskandar Setiawan References: <20220827030236.1094-1-kiizuha@gnuweeb.org> From: Ammar Faizi Subject: Re: [PATCH v2 0/3] New Discord bot and full refactor scripts In-Reply-To: <20220827030236.1094-1-kiizuha@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 8/27/22 10:02 AM, Muhammad Rizki wrote: > Muhammad Rizki (3): > Move the Telegram bot source code > First release Discord bot > Full refactor bot scripts Please split these into smaller manageable-reviewable pieces. I simply can't review it. Each patch should only do one thing. This it too big to review. For example, something like this: Patch #1: daemon: telegram: Move telegram bot source code Patch #2: daemon: discord: Initial Discord bot MySQL table Patch #3: daemon: telegram: Adjust table naming with Discord Patch #4: daemon: discord: Initial Discord bot core (python) Patch #5: daemon: discord: Add feature AAAAAA Patch #6: daemon: discord: Add feature BBBBBB Patch #7: daemon: discord: Add feature CCCCCC ... and so on I want something like that or whatever reviewable. Not this huge diff doing everything in a single patch. This series is crazy and can't be reviewed. -- Ammar Faizi