From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.88.254] (unknown [36.73.79.120]) by gnuweeb.org (Postfix) with ESMTPSA id 42FDA7E595; Sun, 12 Jun 2022 12:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1655036961; bh=ibY0ksgcWE3f75O46bpmfChKH6hVabeFDyyZVDoM94g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IrHHxY/I0L2siRLioEfUR7VuofAdjNW+lXQDz94CGNrUc5OBMd6XWGdoFkvaIgZtl 3m3+BtQhh3HbEiar74sFesyhfIh4AXINljZR0ceY5rQETzghME27Ch8owsydZcAwCq XB80x3HgFv4TWUMYEu0p92H7BTyWdlRQ8m3g/j+O1bPzEEWmlHJfrWzgVsYCzXOpcf m2tmn6N+Abby/O1Pmhyyty2g/OvIvLHX/HkVO+tZJ+J2RvMlgz1nKBGtAoqXc4gSdR NF6WZuXXDgWEir2+n2l/1bLxAPf8Pc3AW1DhKJpkwQ/iUOcZ8yYLfat1s4QXhiJvAF E3hAhee0Pb1wA== Message-ID: Date: Sun, 12 Jun 2022 19:29:06 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH buubuu v1 10/10] view: index: Add meta tags for Facebook link preview Content-Language: en-US To: Alviro Iskandar Setiawan , Fernanda Ma'rouf , Akiekano Cc: GNU/Weeb Mailing List , Ammar Alifian Fahdan , Irvan Malik Azantha , Khoiri , Muhammad Irvan Hakim References: <20220612120720.2750101-10-alviro.iskandar@gnuweeb.org> From: Ammar Faizi In-Reply-To: <20220612120720.2750101-10-alviro.iskandar@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 6/12/22 7:07 PM, Alviro Iskandar Setiawan wrote: > + This doesn't look right, you shouldn't hard code the domain name. Create a variable in the controller, pass it to view, and put the domain here. You can use an environment variable for that as well. -- Ammar Faizi