From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by gnuweeb.org (Postfix) with ESMTPS id 8987381892 for ; Tue, 20 Dec 2022 01:59:56 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=H63JL+Ff; dkim-atps=neutral Received: by mail-pj1-f54.google.com with SMTP id js9so10946796pjb.2 for ; Mon, 19 Dec 2022 17:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FP7pZBwpeojgPK7ndku1St5E0tB4v17gcbGcaTcMfpI=; b=H63JL+Ffviesg0mxINbV4eessmrO3czzpzKGIwejfcdiGwLvmrP0s8tR4Z5nM1Yr+A VBWT4NudNQpl54OLcTTWs/AbPV+/HyQb2poJz3QD4LjfAmtzglvPl4r9VJFHkFsj5Xyr OHUJUYp9kkBsQ+GqH7Au4SK3hyTpzaK8Wwvlcr8ldo1OqE0eaq3FHVdxdbnWqQ2DRobL TlXJikFM9BL5feoOCI3uLhwr0V6MWm6Lt3/LyCF3kXPq9hFD+zhANU77jf6zNeJToKFH gODb+azwjCrvo9dxA4QDa2e9AW8DdwHxbWXk0+ByN6jhGSWvP1k8vaCkUjbEGw12w4w0 yLSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FP7pZBwpeojgPK7ndku1St5E0tB4v17gcbGcaTcMfpI=; b=M4KijAw0kFF55t9nXAHgqDYjOhFDfeCaKCyordCvaEPN8dVWIL/2k1lDrvYLMfoTWs U5l7HN4b0X7BcObac0TQfAwJ2OKYoXG1VqJcm8f+imXVg0TAr11Eg1F8FEl98yQ/TkOt vsF51xjKamfdpZxnsucI54kx7/IvjGOkpFduey/0MQey5oScp+YCB7Ylf81RsXKS+Yx+ HBvgtFvxi4K7IRSpDWacyFJaDvCzBz+g2iNPhAUSQuJs8iY9/BN73tIuPtNpjZgmpi+7 g5ZdSS8ea2QyFKREPJ/YYbebLg+r27ZfNMXYkeT2KTxZSO8WUJ6dsa0yOloafsKiiYxL Ggmg== X-Gm-Message-State: ANoB5pneaHdoLpZOVaCF2AH3ysq1EPpMGfg+45GrTBr/+HxGAayGYzuV cxMj1lvf/CkDQXgd9Idt6c5HiwXsOp88Rw== X-Google-Smtp-Source: AA0mqf5eV1NSaFyyD5EjPN3h+CSaReuJtEgrMtXym9RD7d0kHnm6KIh+ZDu7tHaQsUMJ8vQPXzog2g== X-Received: by 2002:a05:6a20:3216:b0:9d:efc0:67 with SMTP id y22-20020a056a20321600b0009defc00067mr74688305pzc.15.1671501595898; Mon, 19 Dec 2022 17:59:55 -0800 (PST) Received: from [192.168.1.2] ([101.128.125.209]) by smtp.gmail.com with ESMTPSA id h26-20020a63211a000000b00460ea630c1bsm7065719pgh.46.2022.12.19.17.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Dec 2022 17:59:55 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 08:59:49 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 03/17] fix: utils: add a substr for the patch media caption Content-Language: en-US To: Alviro Iskandar Setiawan , Muhammad Rizki Cc: Ammar Faizi , GNU/Weeb Mailing List References: <20221219235721.126-1-kiizuha@gnuweeb.org> <20221219235721.126-4-kiizuha@gnuweeb.org> From: Kiizuha In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 20/12/2022 07.29, Alviro Iskandar Setiawan wrote: > On Tue, Dec 20, 2022 at 6:57 AM Muhammad Rizki wrote: >> Add a substr caption for the patch email to avoid media caption too >> long. >> >> Regarding this commit bb8855bf5e, it's forget to add a substr caption >> method, which is it will get media caption too long error for both >> Discord and Telegram bot. >> >> Signed-off-by: Muhammad Rizki > > What about changing the commit message to be something like this? > > Commit bb8855bf5e3 ("Fix the storage management after the refactor was > happened") did not care with the caption length when sending an > attachment. This leads to error when the caption length hits the > limit. Add a substr() call to cut the caption if it's too long to > avoid such an error. I will change it in v4, thanks. > > P.S.: at the "was happened" part. Sorry, IDK what this means.