From: Ammar Nofan Faizi <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>
Cc: GNU/Weeb Mailing List <[email protected]>,
Ammar Faizi <[email protected]>
Subject: Re: [PATCH ncns v1 4/4] chnet: ring: Only notify CQE free slot when it's available
Date: Wed, 17 Aug 2022 00:17:37 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOG64qOqz9vdqkv8KN_+EYb0CEsZ28Dnk2GWGxGTCdff=FW=Dg@mail.gmail.com>
On 8/17/22 12:12 AM, Alviro Iskandar Setiawan wrote:
> On Tue, Aug 16, 2022 at 11:53 PM Ammar Faizi <[email protected]> wrote:
>> In `CNRingCtx::WaitCQE`, we don't actually always need to call
>> `NotifyWaitCQEFreeSlot()`. To reduce the call overhead, just check
>> whether the CQE slot is available or not. If it's available, then call
>> it, otherwise, just don't.
>>
>> Signed-off-by: Ammar Faizi <[email protected]>
>
> This doesn't work, can't even be compiled:
>
> ../../chnet/chnet_ring.cc:381:16: error: use of undeclared identifier 'cq_mask'
> if (cq_size < cq_mask + 1)
> ^
> 1 error generated.
Ah yeah, sorry, that one should be "cq_mask_", not "cq_mask". I have already fixed
it locally, but forgot to amend the commit before sending it to you. Do you want
me to send a v2 revision, or you can fix it yourself?
--
Ammar Faizi
next prev parent reply other threads:[~2022-08-16 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 16:53 [PATCH ncns v1 0/4] chnet ring cleanups Ammar Faizi
2022-08-16 16:53 ` [PATCH ncns v1 1/4] chnet: ring: Refactor SQE handling Ammar Faizi
2022-08-16 16:53 ` [PATCH ncns v1 2/4] chnet: ring: Improve `PostCQE()` waiting mechanism Ammar Faizi
2022-08-16 16:53 ` [PATCH ncns v1 3/4] chnet: ring: Make sure we are holding the lock when calling `cqe_size()` Ammar Faizi
2022-08-16 16:53 ` [PATCH ncns v1 4/4] chnet: ring: Only notify CQE free slot when it's available Ammar Faizi
2022-08-16 17:12 ` Alviro Iskandar Setiawan
2022-08-16 17:17 ` Ammar Nofan Faizi [this message]
2022-08-16 17:23 ` Alviro Iskandar Setiawan
2022-08-16 17:24 ` [PATCH ncns v1 0/4] chnet ring cleanups Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox