From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from sonic304-20.consmr.mail.sg3.yahoo.com (sonic304-20.consmr.mail.sg3.yahoo.com [106.10.242.210]) by gnuweeb.org (Postfix) with ESMTPS id 514768060C for ; Tue, 16 Aug 2022 17:18:04 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=yahoo.com header.i=@yahoo.com header.a=rsa-sha256 header.s=s2048 header.b=pgqJyRbu; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660670281; bh=DFgZrwjQJ8yREVZjEa0PAUahMLqhaY/bBYwaywnnURA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=pgqJyRbufqGfdgDysN4zL4uGdpMYufMW1ZuYGqduWoau71XmAqJXYB0UekXTwmMnUuXPQ8izwQhAAKjlDv0l/8H5Nfk2DIMbjPThA+QAueHlN7Fydldn9tb1seL3SxQP5JBwQXf/41oLBYhoNWKhFO8VbzhfMJDrPmMj3dVF0h1N4zhkAHEUeHH+qMcvjeGCWOrodQlJM9PXlwQ6IfFrprculAawhq/bS6oBro0R18jDbBLfS8CyVi/udukDIoIAqe+Mo/CixWIQ6y5qMJOU/AMEyip6bHIAH02zlK4bYKmJucW2e4y0Vyu7YtjisxTnvCAkRCcuni44jz1At78yYw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660670281; bh=iGeOV3bAaroI/qz6+Z6JJXm2TO44/5ZUJjJHyJEVWLf=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=G7kLDFCTktumdt2wG8Y4CY/Ms0QIk5t2nco91tAt9tcDpofZ8Uzh1jZANsm1yuH/OjVBO6QtESfglePJEIOK5/kkNYGo/r70lkrPHI6W6AbySA47+X7k1zRPlMQwB/zLtnTrRbT6nUWfdWxe5m5N8aRHAqks9HPh5fG8QIQGdxjGIFODM6UrVBskecX70xm+A+YrCUP4pufHp0aHnm/YbnQJfYzvqAY3bYMiR0w0RMHK1pO7YpOToU6rSetbq6qS5VBZCYcLrrkVB4bs9unB3VL+WZv7O9dJe0iGB7lpN+mHwau/WGeFSQfdLbW90Gxzl3YtUJk1sRh+QW9YCOPrXA== X-YMail-OSG: eMWcioEVM1n7yWxC0zRzNnhC5CuvNsTXWJERVnzIrR6ZFl0gGtjoyw1pZJNv6DE 8qqnN25U7VnU2Po22W7pxIkYlYahq_ST9GYD6ILFwzm9rP6KANSUI3MlNSFAZ0UG4N5QkTKTnPnk sTNADD3L9Fx_4qMT62.MmKRJ3_B.qfhhoVjU9GOv3hiPWMLVcm5qyXGCJH1YbFjGz4DlqDoaX2ec p0KuEVdkI7ZC9FQpcVsq.XZNcnj2i0kcPOK8pJlnT.I6TRHnedK6_SN4.2iMS6tOp8.ogTr4atNi SwHJP635NZo6BITB.7jUfwV5TVbgam_IwQRqgkDXhJlMc0b0hltzfHTn27d8xm_j.66NTE.S.c7D tvBmYwtz81d_PnLiIGQEGgJR1YeYLYi.ToGpqSTCcge5c25zG.qE7UMROEpQJ.Y6XpS4kbhfkFB6 4iVS62xc.DhgaS0350MwF8dg_zzjqL3ZYV.JUcb6hhgIyhfY_Alb9UU8i80BfxbLaDwAmd7m7uGU w9Ct77dOXViAqIq7XB7b1N5dS_QaJ8XD56lM8cJkuUgTFz_Y01dxQe6Q7IOJZiu0AUFWVvAic6vz l_ZSpkQhejbtXXbW9XtYySKJ5EX1X3IIebokiMm_Vr7hC.qyQ0354MxvgpYXl5KXD1HLN2VJpJ3j mUnJeYzeylIihhozQEGVmF3TZaO6zlX6bpM1yUKFTmj_rP3nuahri5lHq2izky7VopdJWCKeZ9mv ORHNbV_fPddiZP8BGfo1GqAUhZnfgANoj6Hrv65DdlXvjv_jUq2Suntzr.7Zbn2FaI30EBt5SiQ7 awBJkMLdLJIGqtGFr1tmSLTwZxnb33rSttu_Vrqojre9fuet5xyt08nyuY00fOtFUHt1sNET4ZM6 A8XwRNRUPoIxmV2Y1oVsjtuTovpXEUOrjedTIyvrUtrpNq8xJBWFFwrDwvVi17Yhl36RqWyFAosV QyHRib38y7U9M7jBrlMRtJC07f5VjASa8ue7c_zg8I67162ocW8fXlkTgrq1Z71GAI4mQlbPLrkg uGyxuLieG31Dl2ubI8DYW9MlQiLZ07As5fiMWsZZvDSrkhxFyIcxrOjLgij.BinBlIrLSJ8uTlQS MQNMzvLZEMUaTZdXwjujAFpv6XgyNCkgUzMv3TLqW2f0QV0o59J6hVCE0A0MmGhC1Y4CHcHElV93 KeCHLUFcSq9k8pCLw.mBXQxxjKxu2VqUVP9pw8mx3_To5gUYeSP570vHcMUuM73qSx43ScoOckFT 2cv_C6rAZnHpeNGAqBf1SPUBfHaoyD8u2htynXCtVh9Kjoo7Uctk_kNny0KhzWMINL9nz1ongy8o C0XBr1GNJ0WTkduLpg9ywlbPSVsrvTW9bF2rksOKmutffr1eg.dp4VtXiYTT8zhl0HMsnFoPLHlU IU4YLL_RKzZ5yZ7wdrGdyAIa9CLhsh7AF.6JYP4snhtF39wDtR2KBvrMWaRPdTDpJi_JsV8Z7YyH X0XEPqFw55WDlg_7pB6mVYG.wj4HU7FrR6uGs6PyLCGDzBM7IxMVMoXCPOYRJEaOO_KrIy6Ci_ck DX52sihlpo7PrdkFf8Rb4Skf7tQ4OKJyhNJnw_BYDq1euABUvB6r71VF.o6oKtANnC3m7.jqrZwP 32vNv5zu6GKsBBHwr6QGXfLEfGBEDwFIaR02P6yzNlXl1nvbjrNPN5UtqXW_ZEOr70bDT.lbXdmF k6e1yWkwryZm7sGEKHL2iobxYMYu3dCAa1ewdk0oRQddiH1O1hsXCxd_NjZnrE9iPmbajAahAPiv XajnunXzUysyMGE4q7RESs4LH52QRI_ufj.RDmLyw4.T_uLzyIJgVaVTElo1CetfBhyzsHAj5PnN cNpP3QdJnlSdmt.cbQ_1CJom3UsgACzWNd.6vZ_T2heH_b5.p17IgINcxtBYQWi6_hpfcrNrCExf pt4ZfXmfBWr2o0n0tirjEUDz0Jehz0n5D2QCdg_vWSjIpw5Ml.0QhezbXXvf7ltRKzB51wYoySa. WI_K_kmqeM9GazbH9ur5h.x6k0WJUMNUv4H9XahbV9pKIK81AVTkQanuFWhzwCY4c8.OpExs7J7. ES9L3_rbOMUePtdWw.8lcKlpMhV3HBeJMFdkjILjz698XHSCUDV0XSzUapmf7pGnn_KfUAU18OKl nrGNPbZXwvvlp2JOkSMEbQWLEDzdARkFJwA7L7pT7RBYH.V6HMaYYQlHixmrwR0YMZ1AVPxocQku olk.IyTy6PccbRfBx7dni4Cx_Vp.Hwnmswg99H_yLtnlrxHndtv7IbrYl8zxXQU0N1XJ0Equ7OZr TzIoq_UVnGTcZJBcr.6Uz X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.sg3.yahoo.com with HTTP; Tue, 16 Aug 2022 17:18:01 +0000 Received: by hermes--canary-production-sg3-6f58cd9b5-hxmk8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 347a619770a53141e75d0ed47ffe3092; Tue, 16 Aug 2022 17:17:56 +0000 (UTC) Message-ID: Date: Wed, 17 Aug 2022 00:17:37 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH ncns v1 4/4] chnet: ring: Only notify CQE free slot when it's available Content-Language: en-US To: Alviro Iskandar Setiawan Cc: GNU/Weeb Mailing List , Ammar Faizi References: <20220816165314.3875649-1-ammarfaizi2@gnuweeb.org> <20220816165314.3875649-5-ammarfaizi2@gnuweeb.org> From: Ammar Nofan Faizi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20531 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo List-Id: On 8/17/22 12:12 AM, Alviro Iskandar Setiawan wrote: > On Tue, Aug 16, 2022 at 11:53 PM Ammar Faizi wrote: >> In `CNRingCtx::WaitCQE`, we don't actually always need to call >> `NotifyWaitCQEFreeSlot()`. To reduce the call overhead, just check >> whether the CQE slot is available or not. If it's available, then call >> it, otherwise, just don't. >> >> Signed-off-by: Ammar Faizi > > This doesn't work, can't even be compiled: > > ../../chnet/chnet_ring.cc:381:16: error: use of undeclared identifier 'cq_mask' > if (cq_size < cq_mask + 1) > ^ > 1 error generated. Ah yeah, sorry, that one should be "cq_mask_", not "cq_mask". I have already fixed it locally, but forgot to amend the commit before sending it to you. Do you want me to send a v2 revision, or you can fix it yourself? -- Ammar Faizi