Re: [PATCH v2 05/11] telegram: Implement the DaemonException() and refactor report_err()

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 08/01/2023 14.23, Ammar Faizi wrote:
> On Sun, Jan 08, 2023 at 02:15:38PM +0700, Alviro Iskandar Setiawan wrote:
>> Maybe you need to give a small pseudo-code so it's clear to him.
> 
> Like I didn't? I definitely did that. Please stop this retardation. I'm
> very tired of getting ignored when giving reviews. Let me emphasize it
> with a block of comment this time.
> 
>          url = None
>          try:
>                  for url in self.db.get_atom_urls():
>                          await self.__handle_atom_url(url)
>          except (OperationalError, DatabaseError) as e:
>                  await self.handle_db_error(e)
>          except DaemonException as e:
>                  e.set_atom_url(url)
>                  await self.client.report_err(e)
>          except:
>                  #
>                  # This is needed because if an exception is
>                  # raised inside self.db.get_atom_urls(), we
>                  # will catch it here.
>                  #
>                  # At this point, we have an atom_url, but
>                  # no thread_url.
>                  #
> 
>                  e = DaemonException()
>                  e.set_atom_url(url)
>                  e.set_thread_url(None)
>                  await self.client.report_err(e)

OK, I'll implement this.

> 
> 
>> My understanding will be adding an "except" statement without specifying
>> any exception class name, no?
> 
> Yes, you are correct.
>