From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by gnuweeb.org (Postfix) with ESMTPS id CE6977E3BB for ; Thu, 21 Apr 2022 11:44:29 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=DCOasWnT; dkim-atps=neutral Received: by mail-pj1-f52.google.com with SMTP id w5-20020a17090aaf8500b001d74c754128so281640pjq.0 for ; Thu, 21 Apr 2022 04:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to:cc :references:from:subject:in-reply-to:content-transfer-encoding; bh=Cp5Up0LrSho0GDgkM58ffKNnMeqDgC1ngKbkriHUeDE=; b=DCOasWnT/TubABiEGuyI0X+v+QATOqQorp/1q3AFJyrFhSOFII1DRR71QaumRx+F22 W6yAswj8ifjQ9xXU32ElNSRkuN79g2NjUM2k85dyJcbooxWjST6zVclLLArVy9ShMR+u FMfyRh+swoFCFsjCCu2+V4DRhBKhIGpM2vSSK99wfvMMjIGMONCmv+7S3SqAjpiqT0cA +4HASk1DIAQmDfCUOnnNjyqfP7KfoAkjHLwXewsGMKVfy4p3mngIO0yvHlBW/CnT40VL +IyD9b7YDwMtpLjgLwNzxUTdfe/wmZAHak4oisJGULH+f1wDBStrugki9OmZOWNQPz8y r5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=Cp5Up0LrSho0GDgkM58ffKNnMeqDgC1ngKbkriHUeDE=; b=35awvYrYjv7rUyEkwyvLNFQGAyYU6LSo4AdQ2mMV3bzaGi9BASVOC7t9JsU0h4MVX5 s81I1ZnFNnXowK5pwWeDXm9QgJVD6S26DQ5YZbj615mnFd3381H3c5Pv8H9PjcXHYOdA BluOpxEvfE+xz4aut655aJd/cBCzVAcRchMK0Gu6mUhzAzjyma6MgTxYGEgLQr6Ube2k ltNlSJA4GTX8SGohWVhy+OUaMz3SZAqtkE4NOaYqC+exES/jsoFyjGp+gvNGLM01PkM9 bM+ETFkP17iWtfDF1+Q/Zs9uBDAy5gUUUMyp4lqDMJnJWNYfzCrqfTctqhyuwzevr43T VpVw== X-Gm-Message-State: AOAM53242h3O9xes1Q4wbPlmz9HLIMW7j8w6fDGOPl0asbLu6SuFUn2n zZG759g+HGajjcqXjSFutvs= X-Google-Smtp-Source: ABdhPJwgjulZoDidtGIATXbgK3CaN+ZiGQFtY9e0gIflthwIqWRt2krPdE9pMYBNX50PoYTZshnqDg== X-Received: by 2002:a17:903:40ce:b0:158:8178:8563 with SMTP id t14-20020a17090340ce00b0015881788563mr24470764pld.167.1650541469220; Thu, 21 Apr 2022 04:44:29 -0700 (PDT) Received: from [192.168.88.87] ([36.72.213.118]) by smtp.gmail.com with ESMTPSA id x71-20020a62864a000000b0050ad2c24a39sm3439780pfd.205.2022.04.21.04.44.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 04:44:28 -0700 (PDT) Message-ID: Date: Thu, 21 Apr 2022 18:44:23 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Dylan Yudaken Cc: Jens Axboe , Pavel Begunkov , io-uring Mailing List , kernel-team@fb.com References: <20220421091427.2118151-1-dylany@fb.com> <20220421091427.2118151-6-dylany@fb.com> From: Ammar Faizi Subject: Re: [PATCH liburing 5/5] overflow: add tests In-Reply-To: <20220421091427.2118151-6-dylany@fb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 4/21/22 4:14 PM, Dylan Yudaken wrote: > Add tests that verify that overflow conditions behave appropriately. > Specifically: > * if overflow is continually flushed, then CQEs should arrive mostly in > order to prevent starvation of some completions > * if CQEs are dropped due to GFP_ATOMIC allocation failures it is > possible to terminate cleanly. This is not tested by default as it > requires debug kernel config, and also has system-wide effects > > Signed-off-by: Dylan Yudaken > --- Dylan, this breaks -Werror build with clang-15. ``` cq-overflow.c:188:15: error: variable 'drop_count' set but not used [-Werror,-Wunused-but-set-variable] unsigned int drop_count = 0; ^ 1 error generated. make[1]: *** [Makefile:210: cq-overflow.t] Error 1 make[1]: *** Waiting for unfinished jobs.... ``` Maybe you miss something that you forgot to use the value of @drop_count? -- Ammar Faizi