From: Ammar Faizi <[email protected]>
To: Muhammad Rizki <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: Re: [RFC PATCH v1 05/17] [telegram] Refactor the Telegram bot
Date: Sun, 11 Sep 2022 20:39:20 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 9/11/22 5:33 PM, Muhammad Rizki wrote:
> I want to refactor this, I move the Telegram bot runner script outside
> the telegram directory and rename is as `tg.py` because there will be a
> Discord bot for `dc.py`.
>
> I make some changes of the codes on import that
> are affected for this refactor. This cannot be splitted between commits
> because if it's splitted will be producing errors.
>
> Signed-off-by: Muhammad Rizki <[email protected]>
Can we stop using "I want to" in every commit message? I don't like
reading this sentence. Please use a persuasive flavor for the commit
message. For example, this one can be like ths:
---------------
Subject: [RFC PATCH v1 05/17] telegram: Refactor the Telegram bot runner
Refactor the Telegram bot runner. Move the Telegram bot runner script
outside the telegram directory and rename it to `tg.py`. While in
there, adapt the import statements for Telegram bot to avoid breakage
after the file movement.
Reasoning:
We will have a Discord bot that lives in `dc.py` in the same directory
with `tg.py`. This way `dc.py` and `tg.py` can share the same modules,
thus reduce code duplication later.
Signed-off-by: Your Name <[email protected]>
---------------
Please massage the message yourself.
--
Ammar Faizi
next prev parent reply other threads:[~2022-09-11 13:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 10:33 [RFC PATCH v1 00/17] Refactor Telegram & initial work Discord Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 01/17] [telegram] Move the Telegram bot source code Muhammad Rizki
2022-09-11 13:16 ` Ammar Faizi
2022-09-11 16:38 ` Muhammad Rizki
2022-09-12 0:13 ` Ammar Faizi
2022-09-11 10:33 ` [RFC PATCH v1 02/17] [telegram] Refactor Telegram bot database method Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 03/17] [telegram] Renaming some functions in scraper/bot.py Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 04/17] Add ignore file for .env Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 05/17] [telegram] Refactor the Telegram bot Muhammad Rizki
2022-09-11 13:39 ` Ammar Faizi [this message]
2022-09-11 10:33 ` [RFC PATCH v1 06/17] [telegram] Renames in telegram mailer directory Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 07/17] Move scraper and utility file Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 08/17] [discord] Initial work Discord bot Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 09/17] [discord] Add success run notice on_ready event Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 10/17] [discord] Add error handler on events Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 11/17] Move db.sql to combine database with Discord and Telegram Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 12/17] [discord] Add database tables for Discord bot Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 13/17] [discord] Add initial Discord bot database instance Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 14/17] [discord] Add save_atom() in database insertion Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 15/17] [discord] Add save_broadcast() " Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 16/17] [discord] Add save_discord_mail() " Muhammad Rizki
2022-09-11 10:33 ` [RFC PATCH v1 17/17] [discord] Add save_email() " Muhammad Rizki
2022-09-11 13:24 ` [RFC PATCH v1 00/17] Refactor Telegram & initial work Discord Ammar Faizi
2022-09-11 16:43 ` Muhammad Rizki
2022-09-11 13:47 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox