From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [172.16.0.2] (unknown [8.34.202.23]) by gnuweeb.org (Postfix) with ESMTPSA id 2CB7680BE8; Sun, 11 Sep 2022 13:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662903564; bh=7pENP8Rj01y9823tMpZ/qcLua03pM3JHXzvcw1hJ5Lk=; h=Date:To:Cc:References:From:Subject:In-Reply-To:From; b=MDWyU9wA32LbzehxX3/8OzbRLHfzTUvFEjvI9RSA2ba95PJPLzlEgpO2SUVUoVtYi FSruEUCNAEMg0BCs8+zr0ICPrgkrI7qwxsfg9bayMU5Er1rL/fc1VZaOXxV7ZmXBii mAZDwVZoWcDRSnvSHVcnzxeqSoXsY3ouUE9pmlZsKO+QPPjYLzSJSGF7VotGRvr5D9 Q3yFp61e5BtaktGneimz36AenpZ0rJVOF3VDn54CA0hkiq3+XjZ36Sznwyf8+mOcvA ImSRAvQBOlyL3PZL8WImWUXi3x/BUEEYej4DSlkwi0exSdcKKtmUs6V3akDQ9HgaAP Y3GEQ/FrsxQkA== Message-ID: Date: Sun, 11 Sep 2022 20:39:20 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Muhammad Rizki Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List References: <20220911103323.1949-1-kiizuha@gnuweeb.org> <20220911103323.1949-6-kiizuha@gnuweeb.org> From: Ammar Faizi Subject: Re: [RFC PATCH v1 05/17] [telegram] Refactor the Telegram bot In-Reply-To: <20220911103323.1949-6-kiizuha@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 9/11/22 5:33 PM, Muhammad Rizki wrote: > I want to refactor this, I move the Telegram bot runner script outside > the telegram directory and rename is as `tg.py` because there will be a > Discord bot for `dc.py`. > > I make some changes of the codes on import that > are affected for this refactor. This cannot be splitted between commits > because if it's splitted will be producing errors. > > Signed-off-by: Muhammad Rizki Can we stop using "I want to" in every commit message? I don't like reading this sentence. Please use a persuasive flavor for the commit message. For example, this one can be like ths: --------------- Subject: [RFC PATCH v1 05/17] telegram: Refactor the Telegram bot runner Refactor the Telegram bot runner. Move the Telegram bot runner script outside the telegram directory and rename it to `tg.py`. While in there, adapt the import statements for Telegram bot to avoid breakage after the file movement. Reasoning: We will have a Discord bot that lives in `dc.py` in the same directory with `tg.py`. This way `dc.py` and `tg.py` can share the same modules, thus reduce code duplication later. Signed-off-by: Your Name --------------- Please massage the message yourself. -- Ammar Faizi