public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Muhammad Rizki <[email protected]>
Cc: Muhammad Rizki <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v2 12/18] Fix indentation issue
Date: Tue, 19 Jul 2022 15:15:05 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 7/19/22 7:17 AM, Muhammad Rizki wrote:
> From: Muhammad Rizki <[email protected]>
> 
> I found indentation issue in packages/client.py where tab and spaces are
> combined together so I decided to change just 8-tab only.
> 
> Signed-off-by: Muhammad Rizki <[email protected]>

This should've been folded into patch #7. Just rebase edit your patch #7
and fix the indentation there.

Don't add extra patch to fix your previous patch unless _the commit to be
fixed_ has already landed in master.

-- 
Ammar Faizi

  reply	other threads:[~2022-07-19  8:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  0:17 [PATCH v2 00/18] Plan to redesign codes Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 01/18] Fix __send_patch_msg function parameter Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 02/18] Fix import problem Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 03/18] Add default temporary directory Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 04/18] Move the Telegram bot session into the storage directory Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 05/18] daemon: Fix raw lore URL on the inline keyboard button Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 06/18] daemon: Use traceback.format_exc() to get the error detail Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 07/18] Re-design send email message to Telegram Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 08/18] Move ____send_patch_msg Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 09/18] Move prepare for patch and clean up patch functions Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 10/18] Create fix_utf8_chars function Muhammad Rizki
2022-07-19  8:20   ` Ammar Faizi
2022-07-19  0:17 ` [PATCH v2 11/18] Recode some codes Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 12/18] Fix indentation issue Muhammad Rizki
2022-07-19  8:15   ` Ammar Faizi [this message]
2022-07-19  0:17 ` [PATCH v2 13/18] Remove whitespace Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 14/18] Remove prepare patch and clean up patch Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 15/18] daemon: Remove unused imports Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 16/18] daemon: Add @handle_flood decorator and remove some functions Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 17/18] daemon: Remove __send_patch_msg() Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 18/18] daemon: Remove unused imports Muhammad Rizki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox