[PATCH server-a001 v1 0/2] Install net-tools and MySQL server

[PATCH server-a001 v1 0/2] Install net-tools and MySQL server

[Ammar Faizi]

Hi,

Two patches this time. Install net-tools and MySQL server.
Not much to tell here...

## Patch 1 (Install net-tools)
Install networking tools like netstat and ifconfig. We will often use
them to inspect and troubleshoot network problem.

## Patch 2 (Install MySQL)
We will need a MySQL server as the database for: postfix, dovecot and
mail accounts. This will give us mysql-server v8.

Go review!

Cc: Hazmi Alfarizqi <hzmi@gnuweeb.org>
Cc: Hazmi Alfarizqi <contact@hzmi.xyz>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (2):
  Install net-tools
  Install MySQL server

 Dockerfile           | 4 ++--
 docker-entrypoint.sh | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)


base-commit: 805621a61ed6aaef8ab9ff4dfb667ff1faa486d5
-- 
Ammar Faizi

[PATCH server-a001 v1 1/2] Install net-tools

[Ammar Faizi]

Install networking tools like netstat and ifconfig. We will often use
them to inspect and troubleshoot network problem.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Dockerfile b/Dockerfile
index 5e59701..7d78c86 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -12,7 +12,7 @@ ARG DEBIAN_FRONTEND=noninteractive
 RUN yes | unminimize
 
 # Install base packages
-RUN apt-get update && apt-get -y --no-install-recommends install ca-certificates gnupg htop ncurses-term vim software-properties-common sudo wget
+RUN apt-get update && apt-get -y --no-install-recommends install ca-certificates gnupg htop ncurses-term vim software-properties-common sudo wget net-tools
 
 # Change root password, and create main user
 RUN echo "root:${rootPassword}" | chpasswd \
-- 
Ammar Faizi

Re: [PATCH server-a001 v1 1/2] Install net-tools

[Alviro Iskandar Setiawan]

On Sun, Apr 17, 2022 at 7:51 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> Install networking tools like netstat and ifconfig. We will often use
> them to inspect and troubleshoot network problem.
>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---

LGTM, netstat and ifconfig are useful.

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>

tq

-- Viro

Re: [PATCH server-a001 v1 1/2] Install net-tools

[Hazmi Alfarizqi]

On 17/04/2022 19:51, Ammar Faizi wrote:

> Install networking tools like netstat and ifconfig. We will often use
> them to inspect and troubleshoot network problem.
>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

LGTM, also just a note that we can't do too much with networking inside 
a non privileged container

Reviewed-by: Hazmi Alfarizqi <hzmi@gnuweeb.org>

-- hzmi

[PATCH server-a001 v1 2/2] Install MySQL server

[Ammar Faizi]

We will need a MySQL server as the database for: postfix, dovecot and
mail accounts. This will give us mysql-server v8.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 Dockerfile           | 2 +-
 docker-entrypoint.sh | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Dockerfile b/Dockerfile
index 7d78c86..883d260 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -27,7 +27,7 @@ COPY apt-sources/* /etc/apt/sources.list.d
 # Install server components
 RUN apt-key adv --fetch-keys https://nginx.org/keys/nginx_signing.key \
     && apt-get update \
-    && apt-get -y --no-install-recommends install openssh-server nginx
+    && apt-get -y --no-install-recommends install openssh-server nginx mysql-server
 
 # Mark port 48589/tcp is to be exposed
 EXPOSE 48589/tcp
diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh
index 1d8114d..ba9026c 100755
--- a/docker-entrypoint.sh
+++ b/docker-entrypoint.sh
@@ -2,5 +2,6 @@
 
 service ssh start
 service nginx start
+service mysql start
 
 exec "$@"
-- 
Ammar Faizi

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Alviro Iskandar Setiawan]

On Sun, Apr 17, 2022 at 7:51 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
>
> We will need a MySQL server as the database for: postfix, dovecot and
> mail accounts. This will give us mysql-server v8.
>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---

This patch is lacking in MySQL preparation, like setting up user/pass,
port to be exposed, database, and whatnot. Instead of deferring many
things for next, why not include it in this patch?

Also, it needs persistent storage, container is temporary, but our
database is permanent???

-- Viro

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Ammar Faizi]

On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
> On Sun, Apr 17, 2022 at 7:51 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
>>
>> We will need a MySQL server as the database for: postfix, dovecot and
>> mail accounts. This will give us mysql-server v8.
>>
>> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>> ---
> 
> This patch is lacking in MySQL preparation, like setting up user/pass,
> port to be exposed, database, and whatnot. Instead of deferring many
> things for next, why not include it in this patch?

OK, it's reasonable to have the user setup at this point. I will do that
in the v2.

> Also, it needs persistent storage, container is temporary, but our
> database is permanent???

This is not a Dockerfile problem, it's a container problem. Which is
done at `docker run`. So there is no relevance with mounting host's
directory.

The change is about Dockerfile. And we don't use a docker-compose.yml
here. I don't see the need to involve that. Yes? No? Comment?

-- 
Ammar Faizi

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Alviro Iskandar Setiawan]

On Sun, Apr 17, 2022 at 8:26 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
[...]
> > Also, it needs persistent storage, container is temporary, but our
> > database is permanent???
>
> This is not a Dockerfile problem, it's a container problem. Which is
> done at `docker run`. So there is no relevance with mounting host's
> directory.
>
> The change is about Dockerfile. And we don't use a docker-compose.yml
> here. I don't see the need to involve that. Yes? No? Comment?

Yes, but how do you tell other maintainers to mount the volume
correctly if you don't provide any mechanism in doing this? You should
tell us how to run it too!

-- Viro

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Ammar Faizi]

On 4/17/22 8:34 PM, Alviro Iskandar Setiawan wrote:
> On Sun, Apr 17, 2022 at 8:26 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
>> On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
> [...]
>>> Also, it needs persistent storage, container is temporary, but our
>>> database is permanent???
>>
>> This is not a Dockerfile problem, it's a container problem. Which is
>> done at `docker run`. So there is no relevance with mounting host's
>> directory.
>>
>> The change is about Dockerfile. And we don't use a docker-compose.yml
>> here. I don't see the need to involve that. Yes? No? Comment?
> 
> Yes, but how do you tell other maintainers to mount the volume
> correctly if you don't provide any mechanism in doing this? You should
> tell us how to run it too!

OK, I understand your concern.

The database file that needs to be persistent lives in /var/lib/mysql.

So:

   docker run -v $HOST_DIR_FOR_MYSQL_DATA:/var/lib/mysql ...

something like that...

I will provide something for it in the v2. Anyway, since the mysql user
is managed by a database as well, this will be persistent across docker
run too. Hence, it's the host responsibility to retain the mysql users.

-- 
Ammar Faizi

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Alviro Iskandar Setiawan]

On Sun, Apr 17, 2022 at 8:45 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> On 4/17/22 8:34 PM, Alviro Iskandar Setiawan wrote:
> > On Sun, Apr 17, 2022 at 8:26 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> >> On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
> > [...]
> >>> Also, it needs persistent storage, container is temporary, but our
> >>> database is permanent???
> >>
> >> This is not a Dockerfile problem, it's a container problem. Which is
> >> done at `docker run`. So there is no relevance with mounting host's
> >> directory.
> >>
> >> The change is about Dockerfile. And we don't use a docker-compose.yml
> >> here. I don't see the need to involve that. Yes? No? Comment?
> >
> > Yes, but how do you tell other maintainers to mount the volume
> > correctly if you don't provide any mechanism in doing this? You should
> > tell us how to run it too!
>
> OK, I understand your concern.
>
> The database file that needs to be persistent lives in /var/lib/mysql.
>
> So:
>
>    docker run -v $HOST_DIR_FOR_MYSQL_DATA:/var/lib/mysql ...
>
> something like that...
>
> I will provide something for it in the v2. Anyway, since the mysql user
> is managed by a database as well, this will be persistent across docker
> run too. Hence, it's the host responsibility to retain the mysql users.

I don't think we should retain mysql users! This may break with
different database versions, the "mysql" table is an internal thing
that shouldn't be exported. User setup should always be re-done at
initialization. Maybe you can put it in docker-entrypoint.sh????

-- Viro

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Ammar Faizi]

On 4/17/22 8:52 PM, Alviro Iskandar Setiawan wrote:
> On Sun, Apr 17, 2022 at 8:45 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
>> On 4/17/22 8:34 PM, Alviro Iskandar Setiawan wrote:
>>> On Sun, Apr 17, 2022 at 8:26 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
>>>> On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
>>> [...]
>>>>> Also, it needs persistent storage, container is temporary, but our
>>>>> database is permanent???
>>>>
>>>> This is not a Dockerfile problem, it's a container problem. Which is
>>>> done at `docker run`. So there is no relevance with mounting host's
>>>> directory.
>>>>
>>>> The change is about Dockerfile. And we don't use a docker-compose.yml
>>>> here. I don't see the need to involve that. Yes? No? Comment?
>>>
>>> Yes, but how do you tell other maintainers to mount the volume
>>> correctly if you don't provide any mechanism in doing this? You should
>>> tell us how to run it too!
>>
>> OK, I understand your concern.
>>
>> The database file that needs to be persistent lives in /var/lib/mysql.
>>
>> So:
>>
>>     docker run -v $HOST_DIR_FOR_MYSQL_DATA:/var/lib/mysql ...
>>
>> something like that...
>>
>> I will provide something for it in the v2. Anyway, since the mysql user
>> is managed by a database as well, this will be persistent across docker
>> run too. Hence, it's the host responsibility to retain the mysql users.
> 
> I don't think we should retain mysql users! This may break with
> different database versions, the "mysql" table is an internal thing
> that shouldn't be exported. User setup should always be re-done at
> initialization. Maybe you can put it in docker-entrypoint.sh????

Huh, how come?

By making the data persistent, I don't say we will export the "mysql"
table. If we ever upgrade, we will export and import. But this persistent
storage is meant to retain the data across docker run. Not across MySQL
versions.

Our automatic backup is always doing mysqldump and we don't export the
"mysql" table here.

-- 
Ammar Faizi

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Alviro Iskandar Setiawan]

On Sun, Apr 17, 2022 at 9:03 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> On 4/17/22 8:52 PM, Alviro Iskandar Setiawan wrote:
> > On Sun, Apr 17, 2022 at 8:45 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> >> On 4/17/22 8:34 PM, Alviro Iskandar Setiawan wrote:
> >>> On Sun, Apr 17, 2022 at 8:26 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> >>>> On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
> >>> [...]
> >>>>> Also, it needs persistent storage, container is temporary, but our
> >>>>> database is permanent???
> >>>>
> >>>> This is not a Dockerfile problem, it's a container problem. Which is
> >>>> done at `docker run`. So there is no relevance with mounting host's
> >>>> directory.
> >>>>
> >>>> The change is about Dockerfile. And we don't use a docker-compose.yml
> >>>> here. I don't see the need to involve that. Yes? No? Comment?
> >>>
> >>> Yes, but how do you tell other maintainers to mount the volume
> >>> correctly if you don't provide any mechanism in doing this? You should
> >>> tell us how to run it too!
> >>
> >> OK, I understand your concern.
> >>
> >> The database file that needs to be persistent lives in /var/lib/mysql.
> >>
> >> So:
> >>
> >>     docker run -v $HOST_DIR_FOR_MYSQL_DATA:/var/lib/mysql ...
> >>
> >> something like that...
> >>
> >> I will provide something for it in the v2. Anyway, since the mysql user
> >> is managed by a database as well, this will be persistent across docker
> >> run too. Hence, it's the host responsibility to retain the mysql users.
> >
> > I don't think we should retain mysql users! This may break with
> > different database versions, the "mysql" table is an internal thing
> > that shouldn't be exported. User setup should always be re-done at
> > initialization. Maybe you can put it in docker-entrypoint.sh????
>
> Huh, how come?
>
> By making the data persistent, I don't say we will export the "mysql"
> table. If we ever upgrade, we will export and import. But this persistent
> storage is meant to retain the data across docker run. Not across MySQL
> versions.
>
> Our automatic backup is always doing mysqldump and we don't export the
> "mysql" table here.

oc, tq

-- Viro

Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Ammar Faizi]

On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
> This patch is lacking in MySQL preparation, like setting up user/pass,
> port to be exposed, database, and whatnot.

No for the expose port. We don't expose MySQL port.

Thanks!

-- 
Ammar Faizi