From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.2] (unknown [182.253.183.90])
	by gnuweeb.org (Postfix) with ESMTPSA id 75B85804D1;
	Fri, 28 Oct 2022 19:36:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1666985800;
	bh=J81zk3Qig2kmkS8C5SGKaNlbYOYcJnLHO0XTc9YVUwI=;
	h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
	b=CyFNRZJTdjhYt/9dkdhi2oX95lLKjhUuTh8CsalQOWXai/DTjNZ/PG0GgR/yiU4/B
	 Z3n9iYu2qGBpAO/sW3YafqMwaxAYs6Oq3+HL0F6T4z0oGtlSgpkdKfdYFMehti5AgI
	 TtLcnlosh3b5QplJ0KFyR/bAHFKVZSVZTDtw4BLFIU0f5peYiQSIbizD/UxeZJ33HW
	 0Tvb8fhwsIH3j70fTYD5J4zQ60FmZQM7Qhkfm4ZWxIl7BUmGWACo9dDA4SKFpzb14F
	 clDSLGlJwSVLD2e5VTxqj/hN1FYJrbbI3AP3wbDFGCe/EKU8kkH7k/X27G1NZauxsr
	 f1ShIhTXaoyJw==
Message-ID: <c8e876cc-89a7-3351-c9ec-425ebd1297db@gnuweeb.org>
Date: Sat, 29 Oct 2022 02:36:37 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error
Content-Language: en-US
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221027150823.601914-1-ammarfaizi2@gnuweeb.org>
 <20221027150823.601914-3-ammarfaizi2@gnuweeb.org>
 <CAOG64qN9BZcnz1px8tAj9_Y96FhU1nVMOA58rfs-4nRY6GhWAg@mail.gmail.com>
 <1d500d37-b11b-75fd-38e5-d7f8e0a9b1d4@gnuweeb.org>
 <CAOG64qO8c4gE=HmL-1QQkqenD+T4ezsU=+FCGsth59=CFjyKpw@mail.gmail.com>
 <3a79a587-ddee-9e25-2ac5-b573938b44a9@gnuweeb.org>
 <043f55c3-67d8-9130-aca4-73c59926d2af@gnuweeb.org>
 <CAOG64qNSS6S0geOHHi50Z_sW5ymW4Cb5=JYt5VO3=4-jjh2KhQ@mail.gmail.com>
 <63aa1b63-f7e2-8da3-b16d-0c7e1045d697@gnuweeb.org>
 <CAOG64qOoL3knPRTVcX+jOopt+24vE0C39Y0Jf1-YAnbGhG7LFQ@mail.gmail.com>
 <9ecfe8ab-fa5a-d01a-0b68-bc639f14888f@gnuweeb.org>
 <CAOG64qNBTV1YnckBPtscLp7LGZ+75fwF58VwBCN5U=ue3D_HaA@mail.gmail.com>
 <54c6d514-f8b3-f8bc-f98b-28a1400fac84@gnuweeb.org>
 <CAOG64qPjgf0Yuh90CV-sn8hTra09Xi_mOuUVf_0S_yYjuifS0A@mail.gmail.com>
 <70c6d919-ed0f-d79c-90fa-d689ed2bbd6f@gnuweeb.org>
In-Reply-To: <70c6d919-ed0f-d79c-90fa-d689ed2bbd6f@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 10/29/22 2:34 AM, Ammar Faizi wrote:
> On 10/29/22 2:29 AM, Alviro Iskandar Setiawan wrote:
>> On Sat, Oct 29, 2022 at 2:15 AM Muhammad Rizki <kiizuha@gnuweeb.org> wrote:
>>> Sorry, you mention remove_patch() which function from? Telegram bot
>>> listener __send_mail() ? if yes, that function is already handled by
>>> mutex, see it on telegram/mailer/listener.py of __handle_mail(), in line
>>> 77 it is already hold.
>>
>> Is this function only called from one place?
>> If that's a guarantee, I'm fine with that. But why delete all files,
>> it's the caller's problem that it doesn't call the function properly.
> 
> It's also called from daemon/telegram/packages/client.py.
> 
> That place doesn't hold the mutex anyway.

Correction, that place may hold or may not hold the mutex, depending
where they are called. Another place that calls the remove_patch() is

    daemon/telegram/packages/plugins/commands/scrape.py

This one always doesn't hold the mutex.

-- 
Ammar Faizi