From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.5] (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id 46B437E3B8;
	Tue,  3 Jan 2023 07:17:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1672730246;
	bh=TE0gllF4BhVDbtxylYmlFs41O+AbgDJslGEnmn9PCQw=;
	h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
	b=cA32yateqnnUDtlAmxpal6vDR3o+ity3BT/0+f9crtvvf7TiHfdBdxupKGDzOwaAb
	 GRadp5V98WK8SyWsEwoTXLDekOgxJPWrv9htNF/ynR41svP9aSdFcEKWVRbi/lvL3G
	 N1MeA7lTDF2kP01/Fp3UzGDVZzO6BFO4+KFdgG1Aj190diOdHY3pO/A7wyM8sap+Wq
	 bMEcvTGQSfk8QWyOwPq5Qykiu9MaU54NWdBgeF1SqRvrYFmo522tifv189KNR83NwR
	 eq76z/+CoDrF1rAHdC5TTeuBHhbaME0HcCKM9bpA4jHRik8XltH2kN0CyLOpKfFFgb
	 AbPTxfZulQp0A==
Message-ID: <d1efe39d-31e5-1709-f185-b17901257f2d@gnuweeb.org>
Date: Tue, 3 Jan 2023 14:17:22 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v1 08/13] feat(discord): Implement the report_err()
Content-Language: en-US
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20230103063641.1680-1-kiizuha@gnuweeb.org>
 <20230103063641.1680-9-kiizuha@gnuweeb.org>
 <f3daa336-00c2-ad69-cadc-50012a8a7d9b@gnuweeb.org>
In-Reply-To: <f3daa336-00c2-ad69-cadc-50012a8a7d9b@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 1/3/23 2:14 PM, Ammar Faizi wrote:
> Why don't you implement the same custom exception for Discord?
> 
> The exception issue when reporting the corresponding URL also exists on
> the Discord daemon too. Yes? No?

OK, just took a look at patch #12, and you implemented it there.
But why should we implement the broken report_err() first, then
the fixed report_err() with DaemonException?

I think implementing the old broken exception handling design is
not needed, just go with the DaemonException pattern we agree on.

-- 
Ammar Faizi