Re: [PATCH v2 4/8] atom: Small change for fix_utf8_char()

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 10/20/22 3:38 PM, Muhammad Rizki wrote:
> Change the parameter to unescape with boolean type and change from
> html.escape to html.unescape for the Discord bot.
> 
> Signed-off-by: Muhammad Rizki<kiizuha@gnuweeb.org>
> ---
>   daemon/atom/utils.py | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/daemon/atom/utils.py b/daemon/atom/utils.py
> index a30d5cb..c95612e 100644
> --- a/daemon/atom/utils.py
> +++ b/daemon/atom/utils.py
> @@ -206,7 +206,7 @@ def create_template(thread: Message, platform: str, to=None, cc=None):
>   		if len(ret) >= substr:
>   			ret = ret[:substr] + "..."
>   
> -		ret = fix_utf8_char(ret, platform == "telegram")
> +		ret = fix_utf8_char(ret, platform == "discord")
>   		ret += border
>   
>   	return ret, files, is_patch
> @@ -242,10 +242,10 @@ def remove_patch(tmp):
>   	shutil.rmtree(tmp)
>   
>   
> -def fix_utf8_char(text: str, html_escape: bool = True):
> +def fix_utf8_char(text: str, unescape: bool = True):
>   	t = text.rstrip().replace("�"," ")
> -	if html_escape:
> -		t = html.escape(html.escape(text))
> +	if unescape:
> +		t = html.unescape(html.unescape(text))
>   	return t

This is broken.

I tested this series, but didn't have time to bisect it. After I
managed to bisect the issue, I found that the issue is introduced
by this patch.

See before and after below, anything inside the angle brackets is
gone. The sample is using this email:

https://lore.kernel.org/io-uring/f905c8cb-702f-6b2c-8954-1a736feb1ee7@kernel.dk/raw

-------------
Before this patch:

#ml
From: Jens Axboe <axboe@kernel.dk>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Dylan Yudaken <dylany@meta.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Cc: io-uring Mailing List <io-uring@vger.kernel.org>
Cc: Facebook Kernel Team <kernel-team@fb.com>
Cc: Dylan Yudaken <dylany@fb.com>

-------------
After this patch:

#ml
From: Jens Axboe
To: Ammar Faizi
To: Dylan Yudaken
Cc: Pavel Begunkov
Cc: GNU/Weeb Mailing List
Cc: io-uring Mailing List
Cc: Facebook Kernel Team
Cc: Dylan Yudaken

-- 
Ammar Faizi