GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: GNU/Weeb Mailing List <[email protected]>,
	Alviro Iskandar Setiawan <[email protected]>
Subject: Re: [RFC PATCH v1 4/5] [telegram] Remove unecessary files
Date: Tue, 6 Sep 2022 23:46:25 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 06/09/2022 23.02, Ammar Faizi wrote:
> On 9/6/22 6:19 PM, Muhammad Rizki wrote:
>> Just remove unecessary files because it's already moved to the
>> plugins/commands
> 
> You moved them in patch #1, why not delete these files in the first place?

Yeah, but I don't know yet how to place this commit to the first commit, 
my knowledge only know to place this commit after the fist commit using 
rebase then commit. Or you want to place this commit after the first commit?

> 
>> Signed-off-by: Muhammad Rizki<[email protected]>
>> ---
>>   daemon/telegram/packages/plugins/admin.py  | 42 -----------
>>   daemon/telegram/packages/plugins/scrape.py | 86 ----------------------
>>   2 files changed, 128 deletions(-)
>>   delete mode 100644 daemon/telegram/packages/plugins/admin.py
>>   delete mode 100644 daemon/telegram/packages/plugins/scrape.py
> 
> Can't we squash this into the first patch? Or I missed something?
> 

Yes, but I only know to place it after the first commit, I was wondering 
why this file still exist while the master branch already removed that 
files.

  reply	other threads:[~2022-09-06 16:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 11:19 [RFC PATCH v1 0/5] Refactor some Telegram bot source code Muhammad Rizki
2022-09-06 11:19 ` [RFC PATCH v1 1/5] [telegram] Move the " Muhammad Rizki
2022-09-06 11:19 ` [RFC PATCH v1 2/5] [telegram] Refactor Telegram bot database method Muhammad Rizki
2022-09-06 11:19 ` [RFC PATCH v1 3/5] [telegram] Renaming some functions in scraper/bot.py Muhammad Rizki
2022-09-06 16:11   ` Ammar Faizi
2022-09-06 11:19 ` [RFC PATCH v1 4/5] [telegram] Remove unecessary files Muhammad Rizki
2022-09-06 16:02   ` Ammar Faizi
2022-09-06 16:46     ` Muhammad Rizki [this message]
2022-09-06 16:53       ` Ammar Faizi
2022-09-06 11:19 ` [RFC PATCH v1 5/5] Refactor many files Muhammad Rizki
2022-09-06 16:04   ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox