From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.1.5] (unknown [101.128.125.100]) by gnuweeb.org (Postfix) with ESMTPSA id B57CC7E257; Tue, 6 Sep 2022 16:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662482789; bh=3HlanCXcBKbudKbbsrlXR9TjnvPUo4n3cyut8FTfatY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o9ArSgb/kCxuCVO+G3X/0F+ql3CyjbA13/VhmfYiL16JWeiIIQL7/O+7p70yTpPWR aNSHhr2e3+scNbWuVGaeD9p/qlf8BD2p1oSXoYA1jTyAlNttouLxbeEqjatSXEVUEs zEj2tb2gxSsK8OmcNi6XauYyAgcRVIQo0HWMO42OLvFsHwA1cm3l9GZVkApS9NhfbD NokKqOvHAUigd12o/iLQ9Z7/uJBzDvX5KumRCUmJxI+NENQzbOx3go9cf23yPpuZ2N if8ilW5AERjQQU5xenr5rA1SgF11y5Amd6Y9gGC9v+kTrY4kf6dsUnq2S41H0O7mo4 xl6L+hrxyaLYQ== Message-ID: Date: Tue, 6 Sep 2022 23:46:25 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [RFC PATCH v1 4/5] [telegram] Remove unecessary files To: Ammar Faizi Cc: GNU/Weeb Mailing List , Alviro Iskandar Setiawan References: <20220906111929.1657-1-kiizuha@gnuweeb.org> <20220906111929.1657-5-kiizuha@gnuweeb.org> <96b21e73-ff59-1d1d-8146-aadba17b69c0@gnuweeb.org> Content-Language: en-US From: Muhammad Rizki In-Reply-To: <96b21e73-ff59-1d1d-8146-aadba17b69c0@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: On 06/09/2022 23.02, Ammar Faizi wrote: > On 9/6/22 6:19 PM, Muhammad Rizki wrote: >> Just remove unecessary files because it's already moved to the >> plugins/commands > > You moved them in patch #1, why not delete these files in the first place? Yeah, but I don't know yet how to place this commit to the first commit, my knowledge only know to place this commit after the fist commit using rebase then commit. Or you want to place this commit after the first commit? > >> Signed-off-by: Muhammad Rizki >> --- >>   daemon/telegram/packages/plugins/admin.py  | 42 ----------- >>   daemon/telegram/packages/plugins/scrape.py | 86 ---------------------- >>   2 files changed, 128 deletions(-) >>   delete mode 100644 daemon/telegram/packages/plugins/admin.py >>   delete mode 100644 daemon/telegram/packages/plugins/scrape.py > > Can't we squash this into the first patch? Or I missed something? > Yes, but I only know to place it after the first commit, I was wondering why this file still exist while the master branch already removed that files.