From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.4] (unknown [101.128.112.71])
	by gnuweeb.org (Postfix) with ESMTPSA id 81A3B7E52E;
	Tue, 17 Jan 2023 23:29:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1673998175;
	bh=BC1+B7ZoPESo6d1ROT505S2o5mWcQhjFGi823r/Y46Q=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=pNRnDa+kZfLIOuxbV3zBh13KWvixSH8g319h6enHSooAJuyqzEW+JcNcmdyswhtdD
	 eJOnAmtol77yYwBLJwIZbTTfg3YcAtjdQ2kBrUH1co59379QTzH2ocH60HUD+uo5As
	 4+/f/Epo3C8hYcWCnGaAHnAqkuT0XFxcDlYgbn4tse5A0uF2BSolqH3q9kiiwAuj4g
	 ZZruf4OTU6j+eirfBU/EqgF9tt1CYkqNJGrXx/PFIDiB5Jijo9EY5TqJwLiN8ZVqrg
	 jay/j+fV+WzF7wik0qDOiPtONijf/RrzKHcO2Zdl2d/IbcXz/F5+M+rWDnGeaz1PzD
	 Bc4ZVmH6Uokgg==
Message-ID: <d7de2db4-85d7-25c1-00c7-b914e69836e8@gnuweeb.org>
Date: Wed, 18 Jan 2023 06:29:31 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v1 00/15] Everything about logger changes and some fixes
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20230117221216.1783-1-kiizuha@gnuweeb.org>
 <Y8cq0BzYzicjVgJQ@biznet-home.integral.gnuweeb.org>
Content-Language: en-US
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <Y8cq0BzYzicjVgJQ@biznet-home.integral.gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 18/01/2023 06.10, Ammar Faizi wrote:
> On Wed, Jan 18, 2023 at 05:12:01AM +0700, Muhammad Rizki wrote:
>> Hi sir,
>> This series is about refactor logger method, fix charset issue, and some
>> improvements. In this series we use a simple logging method that so
>> easily to manage logger config using .conf file.
>>
>> - What's new?
>>    v1:
>>      1) Add return type annotation for the send_text_mail() and
>>         send_patch_email() for the Discord bot
> 
> This one breaks runtime:
> 
>      Traceback (most recent call last):
>        File "/root/lore-daemon2/daemon/tg.py", line 11, in <module>
>          from telegram.packages import DaemonTelegram
>        File "/root/lore-daemon2/daemon/telegram/packages/__init__.py", line 1, in <module>
>          from .client import DaemonTelegram
>        File "/root/lore-daemon2/daemon/telegram/packages/client.py", line 17, in <module>
>          from .decorator import handle_flood
>        File "/root/lore-daemon2/daemon/telegram/packages/decorator.py", line 8, in <module>
>          from typing_extensions import ParamSpec, ParamSpecArgs, ParamSpecKwargs
>      ModuleNotFoundError: No module named 'typing_extensions'
> 
> Apparently, that happens because 'typing_extensions' module is missing.
> But you didn't add that to the requirements.txt file. Apart from that,
> I don't see anything immediately wrong. Overall, it looks good to me.
> 
> Please update the requirements.txt file together with that module
> import addition.
> 

My bad, I thought `typing_extensions` is a built-in library.
I realised that we only have 1 `requirements.txt` and it's in the 
`telegram` directory. Should we move it to the root `daemon` directory 
and update the `requirements.txt`?