From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM
	autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.5] (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id 8B2AE7E416;
	Tue,  3 Jan 2023 22:11:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1672783918;
	bh=KGSlFhoeQRRwySz4DeAjpek15hEak3nJv0/ty9VgZIU=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=XHikilOrlkglRXE1Z9LPwoBbAX45RDIsNg27KymU/l1AG9xcYJa13Vq7H92da7Hgp
	 ZqKE1dT0U7A1xZ+z1U3SYYyCDi/KeSz7M/g0qvcekS5FYoqkM+ZPpeLSpNTCcd2Exx
	 eO7jEG1QUmbV+JIwh5HHY9UIRwbD/IzZ7YerxLzoEmGuKBc9ACvu9V/xvB91IXT+oC
	 wtaRfFkW7MMzbdW+q3zptwqqOe3yZ9fYMInXsYJOXWbMDNfaPbew7POFXRy7vyy2aF
	 HOAc7iM+/xpZpLO2R37fzxLyeEiLs+XzLtppvFn5bYWqR90E+1vkpo8f2CPxrTeN1I
	 xiEaFpwpvvBOg==
Message-ID: <d9fd0124-c4d8-0480-2ccb-79e3e22d2c9b@gnuweeb.org>
Date: Wed, 4 Jan 2023 05:11:54 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v1 03/13] refactor(telegram)!: Ensure the Telegram bot has
 been started
Content-Language: en-US
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20230103063641.1680-1-kiizuha@gnuweeb.org>
 <20230103063641.1680-4-kiizuha@gnuweeb.org>
 <5fa120d7-32ab-b560-0c8f-0da64546cf0b@gnuweeb.org>
 <addc9394-d1b2-9a0a-9972-1a552048b0e7@gnuweeb.org>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <addc9394-d1b2-9a0a-9972-1a552048b0e7@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 1/3/23 7:17 PM, Muhammad Rizki wrote:
> No, we should use this method rather than `client.run()`. Why? because
> at the previous commit, we use `client.run()` after the `bot.run()`
> which is the `bot` here is running first before the Telegram bot is
> started/connect to the Telegram MTProto API, previous commit:
> 
> 	sched.start()
> 	
> 	bot.run() 	<- we listen for new emails, if error may
> 			happen, the listener will send the log file
> 			which is require to interact with the Telegram
> 			API.
> 	
> 	client.run()	<- The client is late to start/connect to the
> 			Telegram API.

What does this call ordering have to do with 'idle()'?

I said this:

On 03/01/2023 13.54, Ammar Faizi wrote:
> I agree to have an 'idle()' call, but it addresses a different issue
> w.r.t. the patch subject. Please split the 'idle()' patch into a
> separate patch.

-- 
Ammar Faizi