From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.5] (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id 71A777E3DC;
	Wed,  4 Jan 2023 08:51:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1672822318;
	bh=/kdSh05GwuA9aZC7XkTq8Qv1du0dXH8b8KkwKF9apLo=;
	h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
	b=g8ihg+G4I1eg98jP8xkdIrcyfziNM30qjWZ3d1rjZN4cmZO4d43D/V2PTyZeX6zsM
	 eFJL4snZrnR1UFffBGiNWvWK6XyHWWoJPONvXfyMUTp8T7q8FZJ7FpY9UCEgGVgUAh
	 PASxqdCrCg6EVau0TAAy48BaKqbEPnH2lkaQB0nCIxpIvNsslBrCGl2ICPq4QswXUS
	 KIqEEzVmvBxdL8tf9Ln4jMxChgXFEN6BqRo4TuqU59vnEW15rIrH942R94f9JBQCLJ
	 qLRS2q6NDvSu9XaSsxe+PlvoFPyyhGerUSkSQr1iXz3Sg5oDiBlnHWM0xtG6OWEldy
	 yHust3lJgvbNQ==
Message-ID: <e3e26931-1cd7-3120-72c7-598c6dc7016f@gnuweeb.org>
Date: Wed, 4 Jan 2023 15:51:55 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v1 08/13] feat(discord): Implement the report_err()
Content-Language: en-US
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20230103063641.1680-1-kiizuha@gnuweeb.org>
 <20230103063641.1680-9-kiizuha@gnuweeb.org>
 <f3daa336-00c2-ad69-cadc-50012a8a7d9b@gnuweeb.org>
 <b12ad506-877b-bebb-9e5f-997caa0e8e15@gnuweeb.org>
 <0a41da94-dae1-2285-4438-de6f026dc059@gnuweeb.org>
 <c22b926b-1777-058b-4d2d-1907d9ac9ecf@gnuweeb.org>
 <c3e67d86-acec-97df-2220-dfd6b87174c4@gnuweeb.org>
 <49c42cbf-3d9f-7cfb-be5c-b31efb622d64@gnuweeb.org>
In-Reply-To: <49c42cbf-3d9f-7cfb-be5c-b31efb622d64@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 1/4/23 3:37 PM, Ammar Faizi wrote:
> Side note:
> Splitting changes into multiple parts is fine, but no leaving broken bits
> in the middle.
> 
> If you want a preparation patch, for example writing a big function
> helper. That patch should HAVE zero effect to the runtime. A preparation
> patch should not be doing broken things at runtime.

Let me get this clear. I think this is the proper ordering of the patches:

    1. Remove unnecessary try/except.

    2. Create the DaemonException class.

    3. Create the report_err() function.

    4. Implement report_err() and DaemonException() in the try/except
       block.

-- 
Ammar Faizi