From: Ammar Faizi <[email protected]>
To: Muhammad Rizki <[email protected]>
Cc: GNU/Weeb Mailing List <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>
Subject: Re: [PATCH v3 16/18] Add create_chat_link() function
Date: Sat, 30 Jul 2022 08:22:59 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 7/29/22 8:40 AM, Muhammad Rizki wrote:
> +def create_chat_link(chat: Chat):
> + chat_id_str = str(chat.id).replace("-100","")
> + if chat.invite_link:
> + chat_link = chat.invite_link
> +
> + elif chat.username:
> + chat_link = f"t.me/{chat.username}"
> + else:
> + chat_link = f"t.me/c/{chat_id_str}/1"
> +
> + return chat_link
This can be further simplified. And that replace() should only
be done when needed. Something like this:
def create_chat_link(chat: Chat):
if chat.invite_link:
return chat.invite_link
if chat.username:
return f"t.me/{chat.username}"
chat_id_str = str(chat.id).replace("-100","")
return f"t.me/c/{chat_id_str}/1"
--
Ammar Faizi
next prev parent reply other threads:[~2022-07-30 1:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 1:40 [PATCH v3 00/18] New feature to handle atom URLs and broadcast Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 01/18] Add new table for atom URLs and broadcast chats in db.sql Muhammad Rizki
2022-07-30 1:26 ` Ammar Faizi
2022-07-30 1:33 ` Ammar Faizi
2022-07-30 1:36 ` Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 02/18] Add ATOM_URLS and BROADCAST_CHAT methods Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 03/18] Fix MySQL InternalError: Unread result found Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 04/18] Create /add_atom command Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 05/18] Add utility functions for /add_atom Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 06/18] Refactor database methods Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 07/18] Add insert_atom() in scraper/db.py Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 08/18] Rename admin.py to debugger.py Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 09/18] Add delete_atom() function in scraper/db.py Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 10/18] Add utility function buton_numbers() Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 11/18] Move bot commands related files to packages/plugins/commands/ Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 12/18] Add del_atom callback query Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 13/18] Add insert_broadcast() in scraper/db.py Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 14/18] Add delete_broadcast() " Muhammad Rizki
2022-07-30 1:23 ` Ammar Faizi
2022-07-30 1:28 ` Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 15/18] Create /add_bc bot command Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 16/18] Add create_chat_link() function Muhammad Rizki
2022-07-30 1:22 ` Ammar Faizi [this message]
2022-07-30 1:25 ` Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 17/18] Add /del_bc bot command Muhammad Rizki
2022-07-29 1:40 ` [PATCH v3 18/18] Add del_chat callback query Muhammad Rizki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox