From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.1.2] (unknown [101.128.126.198]) by gnuweeb.org (Postfix) with ESMTPSA id 4259E804D1; Mon, 7 Nov 2022 01:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1667784868; bh=eZ02WX2+66WbfJqEpvWWVgFTq490+AAFbtpb8bz+tcQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HtVBrclRnzvQGi3EAPBXX+aHMUUNiRa1nyxiNKndbroWg5itezR/7gacH+nehijRS 0aDHvYJ0lYefeKYwU7Ka6OdSrwJZbjK6VUF6yqCYAbqPWGiqBiB7yUOOIk8w1bna0l roWowbKaD87icbZVNZOMANbgfhJoM+dBEKuf6CfK4+kKXJVEYtX01PRthViVQoBWAP Kp3xrVgTZ8VkdpSljvKF5+cD3Ags4L4flkw4UWP07ADsRjfkuVtljoRf9efab3Fh1T Pme+mrIXTtlvZaPgf93jsTRcWw6LI12y9aJ22Ybwh+EswX8qWHG5fMK0tJYICvpBT3 9sw4jDnOlwb2g== Message-ID: Date: Mon, 7 Nov 2022 08:34:24 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v1 11/16] telegram: Implement the log message for catching errors Content-Language: en-US To: Ammar Faizi Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List References: <20221104180931.3852-1-kiizuha@gnuweeb.org> <20221104180931.3852-15-kiizuha@gnuweeb.org> <8ce63732-0cdb-e3b0-f292-5433e5b35ff1@gnuweeb.org> <9bce4733-0133-adf9-6291-3a932df80973@gnuweeb.org> <5151f6a6-f87d-1c7f-3333-26adb5223e32@gnuweeb.org> <6d954bf9-096f-626d-2465-43512323277f@gnuweeb.org> <5ab12c59-d8f3-efbe-38c9-0ff92e398741@gnuweeb.org> From: Muhammad Rizki In-Reply-To: <5ab12c59-d8f3-efbe-38c9-0ff92e398741@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: On 07/11/2022 08.31, Ammar Faizi wrote: > On 11/7/22 8:26 AM, Muhammad Rizki wrote: >> IDK the rule about changelog in commit desc must have relevant with the >> "current "series". > > I mean, I don't understand why did you write this: > > v4: >   - Add logger > > v3: >   - Simplify try and except statement (comment from Muhammad Rizki). > > v2: >   * no changes * > > What is v4? > What is v3? > What is v2? > When did the revision happen? You wrote v2 and v3, and the v4 is me. You wrote the v2 and v3 is from the database reconnect patch. > > It makes *zero* sense to have v2 to v4 changelog in v1 patch. > Yes, without further a due, let me just remove them instead :)